refactor(common): modularize Js UDF handling with plan an exec phases#1900
Draft
refactor(common): modularize Js UDF handling with plan an exec phases#1900
Conversation
LNSD
changed the title
LNSD
changed the title
LNSD
force-pushed
the
lnsd/refactor-common-attach-js-udfs
branch
from
60a7b4b to
5325a07
Compare
…ExecContext Centralise table-source attachment in ExecContext so the traversal lives next to the catalog and snapshot state it depends on. - Remove inline `transform_with_subqueries` from `DetachedLogicalPlan::attach_to`; delegate to `ctx.attach()` - Add `ExecContext::attach()` driving the plan traversal via `attach_table_node` - Extract `attach_table_node` as a standalone free function replacing `PlanTable` sources with `QueryableSnapshot` providers - Remove unused imports from `detached_logical_plan.rs` Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
…d execution phases Separate UDF lifecycle into plan-time placeholders and exec-time bindings so the V8 isolate pool is only needed at execution, not during schema resolution. - Add `udfs::plan::PlanJsUdf` and `udfs::exec::ExecJsUdf` to split planning from execution - Introduce `ExecContext::attach()` to rewrite plan UDFs into executable ones in a single traversal - Move `IsolatePool` from `AmpCatalogProvider` into `ExecContext` - Restructure `datasets-derived` functions into `functions.rs` with builder pattern - Remove `js-runtime` dependency from `admin-api` and `datasets-derived` Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-common-attach-js-udfs
branch
from
5325a07 to
9181fc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate UDF lifecycle into plan-time placeholders and exec-time bindings so the
V8 isolate pool is only needed at execution, not during schema resolution.
udfs::plan::PlanJsUdfandudfs::exec::ExecJsUdfto split planning from executionExecContext::attach()to rewrite plan UDFs into executable ones in a single traversalIsolatePoolfromAmpCatalogProviderintoExecContextdatasets-derivedfunctions intofunctions.rswith builder patternjs-runtimedependency fromadmin-apianddatasets-derived