refactor(common): move plan attach logic to exec context#1901
Merged
Conversation
Contributor
Author
|
This is a spinoff from #1900 |
…ExecContext Centralise table-source attachment in ExecContext so the traversal lives next to the catalog and snapshot state it depends on. - Remove inline `transform_with_subqueries` from `DetachedLogicalPlan::attach_to`; delegate to `ctx.attach()` - Add `ExecContext::attach()` driving the plan traversal via `attach_table_node` - Extract `attach_table_node` as a standalone free function replacing `PlanTable` sources with `QueryableSnapshot` providers - Remove unused imports from `detached_logical_plan.rs` Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-common-context-exec-attach
branch
from
2885983 to
ffc5abe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralise table-source attachment in ExecContext so the traversal lives next to the catalog and snapshot state it depends on.
transform_with_subqueriesfromDetachedLogicalPlan::attach_to; delegate toctx.attach()ExecContext::attach()driving the plan traversal viaattach_table_nodeattach_table_nodeas a standalone free function, replacingPlanTablesources withQueryableSnapshotprovidersdetached_logical_plan.rs