Skip to content

Enforce fully_static_link check regardless of NDEBUG #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nradakovic merged 1 commit into from
Jul 23, 2026
Merged

Enforce fully_static_link check regardless of NDEBUG #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/feature_verification/fully_static_link_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
// (/proc/self/maps): a fully static binary maps no shared objects, so no
// mapped file path ends in ".so" (or contains ".so.").

#include <cassert>
#include <fstream>
#include <iostream>
#include <string>
Expand All @@ -30,7 +29,11 @@ namespace {
// which would indicate the binary was NOT fully statically linked.
bool has_shared_object_mappings() {
std::ifstream maps("/proc/self/maps");
assert(maps.is_open() && "could not open /proc/self/maps");
if (!maps.is_open()) {
std::cerr << "FAIL: could not open /proc/self/maps" << std::endl;
// Treat as failure by reporting a shared-object mapping.
return true;
}

std::string line;
while (std::getline(maps, line)) {
Expand All @@ -46,8 +49,13 @@ bool has_shared_object_mappings() {
int main() {
std::cout << "Testing fully_static_link feature (-static)..." << std::endl;

assert(!has_shared_object_mappings() &&
"expected a fully static binary (no .so mappings)");
// Note: the check must not rely on assert(), which is compiled out under
// -DNDEBUG (applied in both fastbuild and opt modes by this toolchain).
if (has_shared_object_mappings()) {
std::cerr << "FAIL: shared object mapped; binary is not fully static"
<< std::endl;
return 1;
}

std::cout << "fully_static_link test passed: no shared objects mapped"
<< std::endl;
Expand Down
Loading