Enforce fully_static_link check regardless of NDEBUG - #112
Merged
Conversation
The fully_static_link test verified its /proc/self/maps scan with assert(), which is compiled out under -DNDEBUG. Since this toolchain applies -DNDEBUG in both fastbuild and opt modes, the check never ran and the test passed unconditionally. Replace the assert() with an explicit error message and non-zero return so the static-linking check is enforced in all compilation modes.
nradakovic
requested review from
AlexanderLanin,
antonkri and
dcalavrezo-qorix
as code owners
July 23, 2026 13:14
antonkri
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fully_static_link test verified its /proc/self/maps scan with assert(), which is compiled out under -DNDEBUG. Since this toolchain applies -DNDEBUG in both fastbuild and opt modes, the check never ran and the test passed unconditionally.
Replace the assert() with an explicit error message and non-zero return so the static-linking check is enforced in all compilation modes.