Skip to content

Enable dropping files onto labels containing ImageView in the workbench #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable dropping files onto labels containing ImageView in the workbench #3102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ....workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2008, 2020 IBM Corporation and others.
* Copyright (c) 2008, 2025 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -87,6 +87,8 @@
import org.eclipse.swt.custom.CTabFolder2Listener;
import org.eclipse.swt.custom.CTabFolderEvent;
import org.eclipse.swt.custom.CTabItem;
import org.eclipse.swt.dnd.DND;
import org.eclipse.swt.dnd.DropTarget;
import org.eclipse.swt.events.ControlEvent;
import org.eclipse.swt.events.ControlListener;
import org.eclipse.swt.events.MouseAdapter;
Expand Down Expand Up @@ -719,6 +721,11 @@ public Object createWidget(MUIElement element, Object parent) {
if (PartStackUtil.isEditorStack(element)) {
createOnboardingControls(tabFolder);
initializeOnboardingInformationInEditorStack(tabFolder);
int drop = DND.DROP_COPY | DND.DROP_MOVE | DND.DROP_LINK;
// Bug: eclipse-platform/eclipse.platform.swt/issues/649
Composite dropZone = new Composite(tabFolder, SWT.NONE);// additional Composite/child to support dropping
new Label(dropZone, SWT.NONE);
new DropTarget(dropZone, drop);
}
tabFolder.setMRUVisible(getMRUValue());

Expand Down
4 changes: 2 additions & 2 deletions ....eclipse.e4.ui.tests/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRendererTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ public void testOnboardingRenderedWithCorrectSizeForEditorStack() {
Composite uiContainer = (Composite) ((StackRenderer) partStack.getRenderer()).getUIContainer(partStack);
CTabFolder tabFolder = (CTabFolder) ((Composite) uiContainer.getChildren()[0]).getChildren()[0];
assertNotNull(tabFolder.getChildren());
assertEquals(3, tabFolder.getChildren().length);
assertEquals(4, tabFolder.getChildren().length);

Composite outerOnboardingComposite = (Composite) tabFolder.getChildren()[2];
Rectangle expected = new Rectangle(StackRenderer.ONBOARDING_SPACING, StackRenderer.ONBOARDING_TOP_SPACING,
Expand Down Expand Up @@ -526,7 +526,7 @@ public void testOnboardingIsHiddenWhenEditorOpened() {
Composite uiContainer = (Composite) ((StackRenderer) partStack.getRenderer()).getUIContainer(partStack);
CTabFolder tabFolder = (CTabFolder) ((Composite) uiContainer.getChildren()[0]).getChildren()[0];
assertNotNull(tabFolder.getChildren());
assertEquals(3, tabFolder.getChildren().length);
assertEquals(4, tabFolder.getChildren().length);

Composite outerOnboardingComposite = (Composite) tabFolder.getChildren()[2];
Rectangle expected = new Rectangle(StackRenderer.ONBOARDING_SPACING, StackRenderer.ONBOARDING_TOP_SPACING,
Expand Down
Loading