Enable dropping files onto labels containing ImageView in the workbench #3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsazac
force-pushed
the
workbenchImageFix
branch
from
da2be69 to
f3dd5c6
Compare
elsazac
changed the title
Test Results 2 778 files ±0 2 778 suites ±0 1h 51m 39s ⏱️ + 6m 14s For more details on these failures, see this check. Results for commit 7cd49ec. ± Comparison against base commit 6c10cbf. ♻️ This comment has been updated with latest results. |
elsazac
force-pushed
the
workbenchImageFix
branch
9 times, most recently
from
cec03f2 to
7f03468
Compare
containing an imageView.The issue was previously fixed via eclipse-platform/eclipse.platform.swt#649. However, in the workbench, dropping onto the image still didn’t work. The issue is now resolved by calling a DropTarget on the shell obtained from the active IWorkbenchWindow.
elsazac
force-pushed
the
workbenchImageFix
branch
from
7f03468 to
7cd49ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping a file onto the top of an image wasn't possible on a label containing an imageView. The issue was previously fixed via eclipse-platform/eclipse.platform.swt#649. However, in the workbench image, dropping was yet to be configured.
The issue is now resolved by calling a DropTarget on the shell obtained from the active IWorkbenchWindow.
Fixes :eclipse-platform/eclipse.platform.swt#649