Skip to content

Fix suppressWarnings #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+4 −3
Draft

Fix suppressWarnings #3072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3283ea6
Remove 'deprecation' from @SuppressWarnings as it triggers a compiler
elsazac Jun 27, 2025
0092c8f
Fixup : testing and fixing CI errors
elsazac Jul 23, 2025
b81f21e
Fixup : Testing and fixing CI
elsazac Jul 24, 2025
b5b486c
Version bump(s) for 4.37 stream
eclipse-platform-bot Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: org.eclipse.e4.emf.xpath;deprecated:="This bundle is deprecated since 2025-03 (removal in 2027-03 or later)"
Bundle-Version: 0.6.0.qualifier
Bundle-Version: 0.6.100.qualifier
Bundle-RequiredExecutionEnvironment: JavaSE-17
Require-Bundle: org.eclipse.emf.ecore;bundle-version="2.35.0",
org.eclipse.core.runtime;bundle-version="3.29.0",
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.emf.xpath/src/org/eclipse/e4/emf/xpath/XPathContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
* {@code org.eclipse.e4.ui.workbench.modeling.EModelService#findMatchingElements(org.eclipse.e4.ui.model.application.MApplicationElement, String, Class)}
* instead.
*/
@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)")
//@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally wrong thing to do as it has been deprecated for a very good reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akurtakov Sorry for pushing this,I was only testing the CI errors, and to see why the compiler throws a new warning during the build.; it was just for investigation.

public interface XPathContext {

/**
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.model.workbench/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.e4.ui.model.workbench;singleton:=true
Bundle-Version: 2.4.600.qualifier
Bundle-Version: 2.4.700.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Bundle-RequiredExecutionEnvironment: JavaSE-17
Expand Down
1 change: 1 addition & 0 deletions ...es/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/ModelXPathEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

public class ModelXPathEvaluator {

//testing and fixing CI errors
@SuppressWarnings({ "deprecation", "removal" })
public static <T> Stream<T> findMatchingElements(MApplicationElement searchRoot, String xPath, Class<T> clazz) {
return XPathContextFactory.newInstance().newContext(searchRoot).stream(xPath, clazz);
Expand Down
Loading