Skip to content

Fix suppressWarnings #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix suppressWarnings #3072

wants to merge 4 commits into from
+4 −3

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Jun 27, 2025

Remove 'deprecation' from @SuppressWarnings as it triggers an extra warning.

@elsazac elsazac changed the title fix SuppressWarnings Fix suppressWarnings Jun 27, 2025
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Jun 27, 2025 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From fd1ad722a404101c299eb70201cac5944623c74e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 24 Jul 2025 05:33:11 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
index b2f614a319..6a786675cf 100644
--- a/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.e4.emf.xpath;deprecated:="This bundle is deprecated since 2025-03 (removal in 2027-03 or later)"
-Bundle-Version: 0.6.0.qualifier
+Bundle-Version: 0.6.100.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.emf.ecore;bundle-version="2.35.0",
  org.eclipse.core.runtime;bundle-version="3.29.0",
-- 
2.50.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025 •
edited
Loading

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 38m 44s ⏱️ - 12m 15s
 7 932 tests ±0   7 704 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 351 runs  ±0  22 605 ✅ ±0  746 💤 ±0  0 ❌ ±0 

Results for commit b5b486c. ± Comparison against base commit cb2fa1d.

♻️ This comment has been updated with latest results.

@elsazac elsazac force-pushed the suppress_warning branch 4 times, most recently from b69745f to f0fd6fd Compare July 1, 2025 08:57
@elsazac elsazac force-pushed the suppress_warning branch from f0fd6fd to 23ed5bf Compare July 18, 2025 11:13
@akurtakov
Copy link
Member

The PR adds 6 new warnings. It doesn't look like this is the correct change.

@elsazac elsazac force-pushed the suppress_warning branch from 23ed5bf to 1edaa01 Compare July 23, 2025 11:27
@elsazac
Copy link
Member Author

elsazac commented Jul 23, 2025

The PR adds 6 new warnings. It doesn't look like this is the correct change.

Yeah, I am checking this.

@elsazac elsazac force-pushed the suppress_warning branch 3 times, most recently from 8714113 to 5896ff3 Compare July 24, 2025 05:28
@elsazac elsazac force-pushed the suppress_warning branch from 5896ff3 to b81f21e Compare July 24, 2025 05:28
akurtakov
akurtakov reviewed Jul 24, 2025
View reviewed changes
bundles/org.eclipse.e4.emf.xpath/src/org/eclipse/e4/emf/xpath/XPathContext.java
@@ -27,7 +27,7 @@
* {@code org.eclipse.e4.ui.workbench.modeling.EModelService#findMatchingElements(org.eclipse.e4.ui.model.application.MApplicationElement, String, Class)}
* instead.
*/
@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)")
//@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally wrong thing to do as it has been deprecated for a very good reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akurtakov Sorry for pushing this,I was only testing the CI errors, and to see why the compiler throws a new warning during the build.; it was just for investigation.

@elsazac elsazac marked this pull request as draft July 24, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsazac @eclipse-platform-bot @akurtakov