Skip to content

Ensure Consistent DPI Awareness in getDPI() for Font Calculation #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arunjose696 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −8
Open

Ensure Consistent DPI Awareness in getDPI() for Font Calculation #2884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/FontDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,14 +278,24 @@ public FontData open () {
}

private int getDPI() {
long hDC = OS.GetDC (0);
// We need to use OS.GetDeviceCaps, which is static throughout application
// lifecycle (System DPI Aware), because we use
// DPI_AWARENESS_CONTEXT_UNAWARE_GDISCALED which always depends on the DPI at
// application startup
int dpi = OS.GetDeviceCaps(hDC, OS.LOGPIXELSY);
OS.ReleaseDC (0, hDC);
return dpi;
long currentDpiAwarenessContext = OS.GetThreadDpiAwarenessContext();
try {
if (parent.getDisplay().isRescalingAtRuntime()) {
currentDpiAwarenessContext = OS.SetThreadDpiAwarenessContext(OS.DPI_AWARENESS_CONTEXT_UNAWARE_GDISCALED);
}
long hDC = OS.GetDC(0);
// We need to use OS.GetDeviceCaps, which is static throughout application
// lifecycle (System DPI Aware), because we use
// DPI_AWARENESS_CONTEXT_UNAWARE_GDISCALED which always depends on the DPI at
// application startup
int dpi = OS.GetDeviceCaps(hDC, OS.LOGPIXELSY);
OS.ReleaseDC(0, hDC);
return dpi;
} finally {
if (parent.getDisplay().isRescalingAtRuntime()) {
OS.SetThreadDpiAwarenessContext(currentDpiAwarenessContext);
}
}
}

/**
Expand Down
Loading