Ensure Consistent DPI Awareness in getDPI() for Font Calculation #2884
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
The DPI computed in getDPI() is used to determine the font height for the OS.ChooseFont dialog. Following the change in eclipse-platform@b2c80a4, the thread DPI awareness is set to OS.DPI_AWARENESS_CONTEXT_UNAWARE_GDISCALED before opening the ChooseFont dialog. This commit ensures the same DPI awareness is applied in getDPI() for consistent font size calculation. Fixes eclipse-platform#2866
arunjose696
force-pushed
the
arunjose696/558/wrongFont
branch
from
78d23b7 to
58aa85a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DPI computed in getDPI() is used to determine the font height for the
OS.ChooseFontdialog. Following the change in #1593, the thread DPI awareness is set toOS.DPI_AWARENESS_CONTEXT_UNAWARE_GDISCALEDbefore opening theChooseFontdialog. This commit ensures the same DPI awareness is applied ingetDPI()for consistent font size calculation.Steps to reproduce
1)Open the font dialog from the "Colors and Fonts" preference page of the Eclipse IDE .
2)Without this change when opening the FontDialog on a monitor with zoom 200% and an initial font with size 10, the font size selected in the dialog is 20.
Fixes #2866