fix: add limits include #108

russkel · 2022-07-12T03:34:50Z

Hello,

I was unable to compile xtypes with GCC 11 on Ubuntu 22.04 without implicitly adding this include to UnionTypes.hpp.

Perhaps Ubuntu 22.04 needs to be added to the CI test systems.

--- stderr: is-core                             
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/FieldToString.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/FieldToString.cpp:19:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::default_union_label(size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:17: error: ‘numeric_limits’ is not a member of ‘std’
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                 ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:39: error: expected primary-expression before ‘>’ token
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:42: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                          ^~~
      |                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/Instanceable.hpp:23,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/DynamicType.hpp:22,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/CollectionType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/ArrayType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/FieldToString.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/FieldToString.cpp:19:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/StringTemplate.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/StringTemplate.cpp:18:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::default_union_label(size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:17: error: ‘numeric_limits’ is not a member of ‘std’
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                 ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:39: error: expected primary-expression before ‘>’ token
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:42: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                          ^~~
      |                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/Instanceable.hpp:23,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/DynamicType.hpp:22,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/CollectionType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/ArrayType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/StringTemplate.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/StringTemplate.cpp:18:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/FieldToString.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/FieldToString.cpp:19:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::shrink_label(T, size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:48: error: ‘numeric_limits’ is not a member of ‘std’
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:71: error: expected primary-expression before ‘>’ token
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:74: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                          ^~~
      |                                                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/Instanceable.hpp:23,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/DynamicType.hpp:22,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/CollectionType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/ArrayType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/FieldToString.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/FieldToString.cpp:19:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/StringTemplate.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/StringTemplate.cpp:18:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::shrink_label(T, size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:48: error: ‘numeric_limits’ is not a member of ‘std’
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:71: error: expected primary-expression before ‘>’ token
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:74: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                          ^~~
      |                                                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/Instanceable.hpp:23,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/DynamicType.hpp:22,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/CollectionType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/ArrayType.hpp:21,
                 from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/runtime/StringTemplate.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/runtime/StringTemplate.cpp:18:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Config.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/Config.cpp:19:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::default_union_label(size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:17: error: ‘numeric_limits’ is not a member of ‘std’
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                 ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:39: error: expected primary-expression before ‘>’ token
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:42: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                          ^~~
      |                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandleFactory.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Config.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/Config.cpp:19:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Config.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/Config.cpp:19:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::shrink_label(T, size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:48: error: ‘numeric_limits’ is not a member of ‘std’
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:71: error: expected primary-expression before ‘>’ token
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:74: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                          ^~~
      |                                                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandleFactory.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Config.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/Config.cpp:19:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/systemhandle/RegisterSystem.cpp:19:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::default_union_label(size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:17: error: ‘numeric_limits’ is not a member of ‘std’
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                 ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:39: error: expected primary-expression before ‘>’ token
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:45:42: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   45 |     return std::numeric_limits<int64_t>::max() >> ((sizeof(int64_t) - type_size) * 8);
      |                                          ^~~
      |                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandleFactory.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/systemhandle/RegisterSystem.cpp:19:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
In file included from /home/russ/work/is-workspace/install/xtypes/include/xtypes/xtypes.hpp:26,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/core/Message.hpp:21,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/systemhandle/RegisterSystem.cpp:19:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp: In function ‘constexpr int64_t eprosima::xtypes::shrink_label(T, size_t)’:
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:48: error: ‘numeric_limits’ is not a member of ‘std’
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                ^~~~~~~~~~~~~~
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:71: error: expected primary-expression before ‘>’ token
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                       ^
/home/russ/work/is-workspace/install/xtypes/include/xtypes/UnionType.hpp:53:74: error: ‘::max’ has not been declared; did you mean ‘std::max’?
   53 |     return static_cast<int64_t>(value) & (std::numeric_limits<uint64_t>::max()  >> ((sizeof(int64_t) - type_size) * 8));
      |                                                                          ^~~
      |                                                                          std::max
In file included from /usr/include/c++/11/functional:65,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandleFactory.hpp:23,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/SystemHandle.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/include/is/systemhandle/RegisterSystem.hpp:22,
                 from /home/russ/work/is-workspace/Integration-Service/core/src/systemhandle/RegisterSystem.cpp:19:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
gmake[2]: *** [CMakeFiles/is-core.dir/build.make:76: CMakeFiles/is-core.dir/src/runtime/FieldToString.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: *** [CMakeFiles/is-core.dir/build.make:118: CMakeFiles/is-core.dir/src/runtime/StringTemplate.cpp.o] Error 1
gmake[2]: *** [CMakeFiles/is-core.dir/build.make:132: CMakeFiles/is-core.dir/src/systemhandle/RegisterSystem.cpp.o] Error 1
gmake[2]: *** [CMakeFiles/is-core.dir/build.make:160: CMakeFiles/is-core.dir/src/Config.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:130: CMakeFiles/is-core.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< is-core [5.28s, exited with code 2]

Summary: 2 packages finished [5.62s]
  1 package failed: is-core
  1 package had stderr output: is-core
  6 packages not processed

MiguelBarro

LGTM

Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>

russkel · 2022-12-21T22:46:42Z

@MiguelBarro #111 has a bunch of fixes as well, entirely non-controversial, I needed them to get xtypes working with my setup on ubuntu 22.04.

Ryanf55 · 2023-02-23T02:52:18Z

On Ubuntu 22.04 running ROS2 humble LTS, I can confirm this fixes compilation with g++ 11.3.0. I agree with the fix by @russkel. Since this is a trivial change, can it be merged?

Reference: https://en.cppreference.com/w/cpp/types/numeric_limits

* Fix for eProsima#181 * Updates hash to use eProsima/xtypes#108 Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>

russkel force-pushed the fix-limits-header branch from 7bb918c to 3e22e92 Compare July 12, 2022 03:36

russkel mentioned this pull request Jul 29, 2022

C++20 compatability #111

Open

russkel mentioned this pull request Nov 7, 2022

error in colcon build of is-core ("numeric_limits" and "max") eProsima/Integration-Service#181

Closed

MiguelBarro approved these changes Dec 21, 2022

View reviewed changes

fix: add limits include

9a90860

Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>

MiguelBarro force-pushed the fix-limits-header branch from 3e22e92 to 9a90860 Compare December 21, 2022 15:12

rsanchez15 merged commit 57bc836 into eProsima:main Feb 23, 2023

Ryanf55 added a commit to Ryanf55/Integration-Service that referenced this pull request Feb 23, 2023

Bump to latest main to fix <limit> include error

2fe74a5

* Fix for eProsima#181 * Updates hash to use eProsima/xtypes#108 Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add limits include #108

fix: add limits include #108

Uh oh!

russkel commented Jul 12, 2022 •

edited

Loading

Uh oh!

MiguelBarro left a comment

Uh oh!

russkel commented Dec 21, 2022

Uh oh!

Ryanf55 commented Feb 23, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: add limits include #108

fix: add limits include #108

Uh oh!

Conversation

russkel commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MiguelBarro left a comment

Choose a reason for hiding this comment

Uh oh!

russkel commented Dec 21, 2022

Uh oh!

Ryanf55 commented Feb 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

russkel commented Jul 12, 2022 •

edited

Loading

Ryanf55 commented Feb 23, 2023 •

edited

Loading