Open
Conversation
jparisu
force-pushed
the
feature/databroker-participant
branch
from
1c405b1 to
0a44cea
Compare
jamoralp
reviewed
Jun 16, 2021
Contributor
Author
|
@laura-eprosima please check this PR. |
jparisu
force-pushed
the
feature/databroker-participant
branch
from
ea083bb to
64b4901
Compare
jparisu
changed the title
lauramg15
suggested changes
Jul 19, 2021
lauramg15
suggested changes
Jul 19, 2021
added 10 commits
August 11, 2021 09:28
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
lauramg15
force-pushed
the
feature/databroker-participant
branch
from
e7271ea to
7435086
Compare
rsanchez15
requested changes
Aug 23, 2021
| if (dds_participant_) | ||
| // Depending the SH type, use participant qos or databroker qos | ||
| // TODO : change for databroker alias refactor | ||
| if (config["discovery-server"]) |
There was a problem hiding this comment.
This is to maintain consistency with the rest of the tags.
Suggested change
| if (config["discovery-server"]) | |
| if (config["discovery_server"]) |
| logger_ << utils::Logger::Level::INFO | ||
| << "Created Fast DDS participant '" << dds_participant_->get_qos().name() | ||
| << "' from profile configuration '" << profile_name << "'" << std::endl; | ||
| participant_qos = get_databroker_qos(config["discovery-server"]); |
There was a problem hiding this comment.
Suggested change
| participant_qos = get_databroker_qos(config["discovery-server"]); | |
| participant_qos = get_databroker_qos(config["discovery_server"]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jparisu javierparis@eprosima.com