-
Notifications
You must be signed in to change notification settings - Fork 195
Refactor snapshot to sqlc #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4f8922e
Refactor pausing to sqlc
jakubno 0404755
Clean up
jakubno 42a9750
Add comments
jakubno e4678bf
Format
jakubno 7ce2e34
Simplify the query
jakubno 37d1e17
Add tests
jakubno 7d10e74
Make tidy
jakubno e180e34
Clean up
jakubno b1005e8
Improve tests
jakubno fbd8432
Lint
jakubno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| -- name: UpsertSnapshot :one | ||
| WITH new_template AS ( | ||
| INSERT INTO "public"."envs" (id, public, created_by, team_id, updated_at) | ||
| SELECT @template_id, FALSE, NULL, @team_id, now() | ||
| WHERE NOT EXISTS ( | ||
| SELECT id | ||
| FROM "public"."snapshots" s | ||
| WHERE s.sandbox_id = @sandbox_id | ||
| ) RETURNING id | ||
| ), | ||
jakubno marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| -- Create a new snapshot or update an existing one | ||
| snapshot as ( | ||
| INSERT INTO "public"."snapshots" ( | ||
| sandbox_id, | ||
| base_env_id, | ||
| team_id, | ||
| env_id, | ||
| metadata, | ||
| sandbox_started_at, | ||
| env_secure, | ||
| allow_internet_access, | ||
| origin_node_id, | ||
| auto_pause, | ||
| config | ||
| ) | ||
| VALUES ( | ||
| @sandbox_id, | ||
| @base_template_id, | ||
| @team_id, | ||
| -- If snapshot already exists, new_template id will be null, env_id can't be null, so use placeholder '' | ||
| COALESCE((SELECT id FROM new_template), ''), | ||
| @metadata, | ||
| @started_at, | ||
| @secure, | ||
| @allow_internet_access, | ||
| @origin_node_id, | ||
| @auto_pause, | ||
| @config | ||
| ) | ||
| ON CONFLICT (sandbox_id) DO UPDATE SET | ||
| metadata = excluded.metadata, | ||
| sandbox_started_at = excluded.sandbox_started_at, | ||
| origin_node_id = excluded.origin_node_id, | ||
| auto_pause = excluded.auto_pause, | ||
| config = excluded.config | ||
| RETURNING env_id as template_id | ||
| ) | ||
|
|
||
| -- Create a new build for the snapshot | ||
| INSERT INTO "public"."env_builds" ( | ||
| env_id, | ||
| vcpu, | ||
| ram_mb, | ||
| free_disk_size_mb, | ||
| kernel_version, | ||
| firecracker_version, | ||
| envd_version, | ||
| status, | ||
| cluster_node_id, | ||
| total_disk_size_mb, | ||
| updated_at | ||
| ) VALUES ( | ||
| (SELECT template_id FROM snapshot), | ||
| @vcpu, | ||
| @ram_mb, | ||
| @free_disk_size_mb, | ||
| @kernel_version, | ||
| @firecracker_version, | ||
| @envd_version, | ||
| @status, | ||
| @origin_node_id, | ||
| @total_disk_size_mb, | ||
| now() | ||
| ) RETURNING id as build_id, env_id as template_id; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.