Refactor snapshot to sqlc #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
force-pushed
the
refactor-template-build-cache-to-use-sqlc
branch
from
ae8f5f8 to
6cc139b
Compare
Base automatically changed from
refactor-template-build-cache-to-use-sqlc
to
main
September 10, 2025 06:17
jakubno
force-pushed
the
refactor-snapshot-to-sqlc
branch
4 times, most recently
from
b147684 to
698ecf7
Compare
Member
|
@jakubno, is this PR just a reference for the SQLC rewrite? |
ValentaTomas
changed the title
Member
Author
|
I will be returning to this very soon |
jakubno
force-pushed
the
refactor-snapshot-to-sqlc
branch
from
0ff4d46 to
4f8922e
Compare
jakubno
force-pushed
the
refactor-snapshot-to-sqlc
branch
from
719d6a2 to
7ce2e34
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sitole
reviewed
Nov 19, 2025
Comment on lines
42
to
46
| metadata = @metadata, | ||
| sandbox_started_at = @started_at, | ||
| origin_node_id = @origin_node_id, | ||
| auto_pause = @auto_pause, | ||
| config = @config |
Member
There was a problem hiding this comment.
You can use metadata = excluded.metadata here instead of putting the value here again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Switch snapshot creation to a new sqlc
UpsertSnapshotand update orchestrator to use it, with added tests and removal of legacy Ent-based code.UpsertSnapshot: Add SQL and generated code to upsert snapshots and create correspondingenv_builds(packages/db/queries/snapshots/create_new_snapshot.sql, generatedcreate_new_snapshot.sql.go).upsert_snapshot_test.gocovering new, existing, and repeated upserts; include raw SQL test helpers inpackages/db/client/tests.go.pause_instance.goto callsqlcDB.UpsertSnapshot, pass structured params, and use returnedtemplate_id/build_idfor snapshotting and status update.SnapshotInfo,NewSnapshotBuild) frompackages/shared/pkg/db/snapshot.go.Written by Cursor Bugbot for commit fbd8432. This will update automatically on new commits. Configure here.