Skip to content

[LibraryImportGenerator] Update diagnostic titles to use localized strings #68533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

elinor-fung
Copy link
Member

The analyzer diagnostics were using localized strings for the message and description, but not the title.

Also collapses a few of the more specific IDs into existing ones.

@ghost
Copy link

ghost commented Apr 26, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

The analyzer diagnostics were using localized strings for the message and description, but not the title.

Also collapses a few of the more specific IDs into existing ones.

Author: elinor-fung
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: 7.0.0

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at someone updating all the xlf files :-P

Do we need to update the shipped diagnostics in the txt file? I thought they were the numbered values.

@elinor-fung
Copy link
Member Author

Are you talking about the list-of-diagnostics file? We will. We still need to switch these all to use the SYSLIB prefix (planning on doing that after this change) and will update that file at the same time.

@@ -345,7 +345,7 @@ public static class MissingMemberNames
public static readonly DiagnosticDescriptor LinearCollectionElementTypesMustMatchRule =
new DiagnosticDescriptor(
Ids.InvalidSignaturesInMarshallerShape,
"InvalidSignaturesInMarshallerShape",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious do we consistently use Marshaller spelling? As opposed to Marshaler.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of two-ish years ago, yes. Our new APIs / code should be consistently using the double l. We settled on: marshal, marshalling, marshalled, marshaller. We've also been working with docs style guide owners to try to get an entry added.

@elinor-fung
Copy link
Member Author

Failure is #66571

@elinor-fung elinor-fung merged commit 1d0589b into dotnet:main Apr 26, 2022
@elinor-fung elinor-fung deleted the diagnosticTitles branch April 26, 2022 16:43
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants