-
Notifications
You must be signed in to change notification settings - Fork 5k
[LibraryImportGenerator] Update diagnostic titles to use localized strings #68533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThe analyzer diagnostics were using localized strings for the message and description, but not the title. Also collapses a few of the more specific IDs into existing ones.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at someone updating all the xlf files :-P
Do we need to update the shipped diagnostics in the txt file? I thought they were the numbered values.
Are you talking about the list-of-diagnostics file? We will. We still need to switch these all to use the |
@@ -345,7 +345,7 @@ public static class MissingMemberNames | |||
public static readonly DiagnosticDescriptor LinearCollectionElementTypesMustMatchRule = | |||
new DiagnosticDescriptor( | |||
Ids.InvalidSignaturesInMarshallerShape, | |||
"InvalidSignaturesInMarshallerShape", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious do we consistently use Marshaller spelling? As opposed to Marshaler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of two-ish years ago, yes. Our new APIs / code should be consistently using the double l
. We settled on: marshal, marshalling, marshalled, marshaller. We've also been working with docs style guide owners to try to get an entry added.
Failure is #66571 |
The analyzer diagnostics were using localized strings for the message and description, but not the title.
Also collapses a few of the more specific IDs into existing ones.