[LibraryImportGenerator] Update diagnostic titles to use localized strings (#68533)

Author: elinor-fung

src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeMarshallingAttribute.cs

@@ -16,7 +16,7 @@ namespace System.Runtime.InteropServices
     public sealed class NativeMarshallingAttribute : Attribute
     {
         /// <summary>
-        /// Create a <see cref="MarshalUsingAttribute" /> that provides a native marshalling type.
+        /// Create a <see cref="NativeMarshallingAttribute" /> that provides a native marshalling type.
         /// </summary>
         /// <param name="nativeType">The marshaller type used to convert the attributed type from managed to native code. This type must be attributed with <see cref="CustomTypeMarshallerAttribute" /></param>
         public NativeMarshallingAttribute(Type nativeType)

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs

@@ -18,18 +18,14 @@ public static class Ids
             // Migration from DllImport to LibraryImport
             public const string ConvertToLibraryImport = Prefix + "001";
 
-            // ManualTypeMarshalling
-            public const string MarshallerTypeMustSpecifyManagedType = Prefix + "002";
-            public const string CustomTypeMarshallerAttributeMustBeValid = Prefix + "003";
-            public const string InvalidNativeType = Prefix + "004";
-            public const string GetPinnableReferenceReturnTypeBlittable = Prefix + "005";
-            public const string CustomMarshallerTypeMustHaveRequiredShape = Prefix + "006";
-            public const string CustomMarshallerTypeMustSupportDirection = Prefix + "007";
-            public const string ProvidedMethodsNotSpecifiedInShape = Prefix + "008";
-            public const string MissingAllocatingMarshallingFallback = Prefix + "009";
-            public const string CallerAllocConstructorMustHaveBufferSize = Prefix + "010";
-            public const string InvalidSignaturesInMarshallerShape = Prefix + "011";
-            public const string MarshallerGetPinnableReferenceRequiresTwoStageMarshalling = Prefix + "012";
+            // CustomTypeMarshaller
+            public const string InvalidCustomTypeMarshallerAttributeUsage = Prefix + "002";
+            public const string InvalidNativeType = Prefix + "003";
+            public const string CustomMarshallerTypeMustHaveRequiredShape = Prefix + "004";
+            public const string ProvidedMethodsNotSpecifiedInFeatures = Prefix + "005";
+            public const string MissingAllocatingMarshallingFallback = Prefix + "006";
+            public const string CallerAllocConstructorMustHaveBufferSize = Prefix + "007";
+            public const string InvalidSignaturesInMarshallerShape = Prefix + "008";
         }
 
         internal static LocalizableResourceString GetResourceString(string resourceName)

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomTypeMarshallerAnalyzer.cs

@@ -99,7 +99,7 @@ private static async Task AddMissingFeatures(FixAllContext fixAllContext, Docume
             ImmutableArray.Create(
                 AnalyzerDiagnostics.Ids.CustomMarshallerTypeMustHaveRequiredShape,
                 AnalyzerDiagnostics.Ids.MissingAllocatingMarshallingFallback,
-                AnalyzerDiagnostics.Ids.ProvidedMethodsNotSpecifiedInShape);
+                AnalyzerDiagnostics.Ids.ProvidedMethodsNotSpecifiedInFeatures);
 
         public override async Task RegisterCodeFixesAsync(CodeFixContext context)
         {
@@ -158,7 +158,7 @@ private static (CustomTypeMarshallerFeatures featuresToAdd, List<Diagnostic> fix
             CustomTypeMarshallerFeatures featuresToAdd = CustomTypeMarshallerFeatures.None;
             foreach (var diagnostic in diagnostics)
             {
-                if (diagnostic.Id == AnalyzerDiagnostics.Ids.ProvidedMethodsNotSpecifiedInShape)
+                if (diagnostic.Id == AnalyzerDiagnostics.Ids.ProvidedMethodsNotSpecifiedInFeatures)
                 {
                     featuresToAddDiagnostics.Add(diagnostic);
                     if (diagnostic.Properties.TryGetValue(CustomTypeMarshallerAnalyzer.MissingFeaturesKey, out string missingFeatures)

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomTypeMarshallerFixer.cs

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!--
-    Microsoft ResX Schema
-
+  <!-- 
+    Microsoft ResX Schema 
+    
     Version 2.0
-
-    The primary goals of this format is to allow a simple XML format
-    that is mostly human readable. The generation and parsing of the
-    various data types are done through the TypeConverter classes
+    
+    The primary goals of this format is to allow a simple XML format 
+    that is mostly human readable. The generation and parsing of the 
+    various data types are done through the TypeConverter classes 
     associated with the data types.
-
+    
     Example:
-
+    
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-
-    There are any number of "resheader" rows that contain simple
+                
+    There are any number of "resheader" rows that contain simple 
     name/value pairs.
-
-    Each data row contains a name, and value. The row also contains a
-    type or mimetype. Type corresponds to a .NET class that support
-    text/value conversion through the TypeConverter architecture.
-    Classes that don't support this are serialized and stored with the
+    
+    Each data row contains a name, and value. The row also contains a 
+    type or mimetype. Type corresponds to a .NET class that support 
+    text/value conversion through the TypeConverter architecture. 
+    Classes that don't support this are serialized and stored with the 
     mimetype set.
-
-    The mimetype is used for serialized objects, and tells the
-    ResXResourceReader how to depersist the object. This is currently not
+    
+    The mimetype is used for serialized objects, and tells the 
+    ResXResourceReader how to depersist the object. This is currently not 
     extensible. For a given mimetype the value must be set accordingly:
-
-    Note - application/x-microsoft.net.object.binary.base64 is the format
-    that the ResXResourceWriter will generate, however the reader can
+    
+    Note - application/x-microsoft.net.object.binary.base64 is the format 
+    that the ResXResourceWriter will generate, however the reader can 
     read any of the formats listed below.
-
+    
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with
+    value   : The object must be serialized with 
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
-
+    
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with
+    value   : The object must be serialized with 
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array
+    value   : The object must be serialized into a byte array 
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -437,4 +437,25 @@
   <data name="TwoStageMarshallingNativeTypesMustMatchMessage" xml:space="preserve">
     <value>The return type of 'ToNativeValue' and the parameter type of 'FromNativeValue' must be the same</value>
   </data>
+  <data name="CallerAllocConstructorMustHaveBufferSizeTitle" xml:space="preserve">
+    <value>'BufferSize' should be set on 'CustomTypeMarshallerAttribute'</value>
+  </data>
+  <data name="CustomMarshallerTypeMustHaveRequiredShapeTitle" xml:space="preserve">
+    <value>Marshaller type does not have the required shape</value>
+  </data>
+  <data name="InvalidCustomTypeMarshallerAttributeUsageTitle" xml:space="preserve">
+    <value>Invalid `CustomTypeMarshallerAttribute` usage</value>
+  </data>
+  <data name="InvalidNativeTypeTitle" xml:space="preserve">
+    <value>Specified native type is invalid</value>
+  </data>
+  <data name="InvalidSignaturesInMarshallerShapeTitle" xml:space="preserve">
+    <value>Marshaller type has incompatible method signatures</value>
+  </data>
+  <data name="MissingAllocatingMarshallingFallbackTitle" xml:space="preserve">
+    <value>Marshaller type does not support allocating constructor</value>
+  </data>
+  <data name="ProvidedMethodsNotSpecifiedInFeaturesTitle" xml:space="preserve">
+    <value>Marshaller type defines a well-known method without specifying support for the corresponding feature</value>
+  </data>
 </root>

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx

@@ -22,6 +22,11 @@
         <target state="translated">Nativní typ {0} musí nastavit pole BufferSize u použitého atributu System.Runtime.InteropServices.CustomTypeMarshallerAttribute, aby se určila velikost vyrovnávací paměť přidělené volajícímu, protože má konstruktor přebírající „Span&lt;byte&gt;“ přidělený volajícímu.</target>
         <note />
       </trans-unit>
+      <trans-unit id="CallerAllocConstructorMustHaveBufferSizeTitle">
+        <source>'BufferSize' should be set on 'CustomTypeMarshallerAttribute'</source>
+        <target state="new">'BufferSize' should be set on 'CustomTypeMarshallerAttribute'</target>
+        <note />
+      </trans-unit>
       <trans-unit id="CallerAllocMarshallingShouldSupportAllocatingMarshallingFallbackDescription">
         <source>A type that supports marshalling from managed to native using a caller-allocated buffer should also support marshalling from managed to native where using a caller-allocated buffer is impossible.</source>
         <target state="translated">Typ, který podporuje zařazování ze spravovaného na nativní prostřednictvím vyrovnávací paměť přidělené volajícím, by měl zároveň podporovat zařazování ze spravovaného na nativní v případech, kdy není vyrovnávací paměť přidělená volajícím možná.</target>
@@ -132,6 +137,11 @@
         <target state="translated">Převést na LibraryImport s příponou {0}</target>
         <note />
       </trans-unit>
+      <trans-unit id="CustomMarshallerTypeMustHaveRequiredShapeTitle">
+        <source>Marshaller type does not have the required shape</source>
+        <target state="new">Marshaller type does not have the required shape</target>
+        <note />
+      </trans-unit>
       <trans-unit id="CustomMarshallerTypeMustSupportDirectionDescription">
         <source>A native must set the 'Direction' property on the 'CustomTypeMarshallerAttribute' to a value that sets at least one known flag value on the 'CustomTypeMarshallerDirection' enum</source>
         <target state="translated">Nativní musí nastavit vlastnost „Direction“ u atributu CustomTypeMarshallerAttribute na hodnotu, která nastavuje alespoň jednu hodnotu příznaku na výčtu CustomTypeMarshallerDirection</target>
@@ -227,11 +237,26 @@
         <target state="translated">Metoda {0} by měla mít vlastnost „static“, „partial“ a non-generic, když je označena atributem LibraryImportAttribute. Generování zdroje voláním P/Invoke bude metodu {0} ignorovat.</target>
         <note />
       </trans-unit>
+      <trans-unit id="InvalidCustomTypeMarshallerAttributeUsageTitle">
+        <source>Invalid `CustomTypeMarshallerAttribute` usage</source>
+        <target state="new">Invalid `CustomTypeMarshallerAttribute` usage</target>
+        <note />
+      </trans-unit>
       <trans-unit id="InvalidLibraryImportAttributeUsageTitle">
         <source>Invalid 'LibraryImportAttribute' usage</source>
         <target state="translated">Neplatné použití LibraryImportAttribute</target>
         <note />
       </trans-unit>
+      <trans-unit id="InvalidNativeTypeTitle">
+        <source>Specified native type is invalid</source>
+        <target state="new">Specified native type is invalid</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="InvalidSignaturesInMarshallerShapeTitle">
+        <source>Marshaller type has incompatible method signatures</source>
+        <target state="new">Marshaller type has incompatible method signatures</target>
+        <note />
+      </trans-unit>
       <trans-unit id="InvalidStringMarshallingConfigurationDescription">
         <source>The configuration of 'StringMarshalling' and 'StringMarshallingCustomType' is invalid.</source>
         <target state="translated">Konfigurace StringMarshalling a StringMarshallingCustomType je neplatná.</target>
@@ -352,6 +377,11 @@
         <target state="translated">Typ {0} neurčuje spravovaný typ v atributu System.Runtime.InteropServices.CustomTypeMarshallerAttribute použitém na typ</target>
         <note />
       </trans-unit>
+      <trans-unit id="MissingAllocatingMarshallingFallbackTitle">
+        <source>Marshaller type does not support allocating constructor</source>
+        <target state="new">Marshaller type does not support allocating constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="NativeGenericTypeMustBeClosedOrMatchArityDescription">
         <source>The native type '{0}' must be a closed generic or have the same number of generic parameters as the managed type so the emitted code can use a specific instantiation.</source>
         <target state="translated">Nativní typ {0} musí být uzavřený obecný typ nebo musí mít stejný počet obecných parametrů jako spravovaný typ, aby mohl vygenerovaný kód použít konkrétní vytvoření instance.</target>
@@ -412,6 +442,11 @@
         <target state="translated">Typ zařazování {0} podporuje zařazování ve směru „Out“ s funkcí TwoStageMarshalling, ale neposkytuje instanční metodu FromNativeValue, která vrací „void“ a přebírá jeden parametr.</target>
         <note />
       </trans-unit>
+      <trans-unit id="ProvidedMethodsNotSpecifiedInFeaturesTitle">
+        <source>Marshaller type defines a well-known method without specifying support for the corresponding feature</source>
+        <target state="new">Marshaller type defines a well-known method without specifying support for the corresponding feature</target>
+        <note />
+      </trans-unit>
       <trans-unit id="RefNativeValueUnsupportedDescription">
         <source>The 'Value' property must not be a 'ref' or 'readonly ref' property.</source>
         <target state="translated">Vlastnost Value nesmí být vlastnost typu „ref“ ani „readonly“.</target>