-
Notifications
You must be signed in to change notification settings - Fork 5k
Update build and test images to Alpine 3.22 #116167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richlander
wants to merge
3
commits into
dotnet:main
Choose a base branch
from
richlander:pipeline-update-alpine322
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,23 +77,23 @@ jobs: | |
| # Linux musl x64 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_x64') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - (Alpine.321.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
| - (Alpine.322.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-amd64 | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - (Alpine.321.Amd64)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
| - (Alpine.322.Amd64)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-amd64 | ||
|
|
||
| # Linux musl arm32 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_arm') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - (Alpine.321.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-arm32v7 | ||
| - (Alpine.322.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-arm32v7 | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - (Alpine.321.Arm32)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-arm32v7 | ||
| - (Alpine.322.Arm32)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-arm32v7 | ||
|
|
||
| # Linux musl arm64 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_arm64') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - (Alpine.321.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-arm64v8 | ||
| - (Alpine.322.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-arm64v8 | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - (Alpine.321.Arm64)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-arm64v8 | ||
| - (Alpine.322.Arm64)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-arm64v8 | ||
|
|
||
| # Linux x64 | ||
| - ${{ if eq(parameters.platform, 'linux_x64') }}: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,11 +33,11 @@ jobs: | |
|
|
||
| # Linux musl x64 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_x64') }}: | ||
| - (Alpine.321.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
| - (Alpine.322.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-amd64 | ||
|
|
||
| # Linux musl arm64 | ||
| - ${{ if and(eq(parameters.platform, 'linux_musl_arm64'), or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true))) }}: | ||
| - (Alpine.321.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-arm64v8 | ||
| - (Alpine.322.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-arm64v8 | ||
|
|
||
| # Linux x64 | ||
| - ${{ if eq(parameters.platform, 'linux_x64') }}: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,15 +37,17 @@ jobs: | |
|
|
||
| # Linux musl x64 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_x64') }}: | ||
| - ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - (Alpine.edge.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-edge-helix-amd64 | ||
| # Alpine edge builds should only be used in main | ||
| - ${{ if eq(contains(coalesce(variables['System.PullRequest.TargetBranch'], variables['Build.SourceBranch'], ''), 'main'), 'true') }}: | ||
| - ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - (Alpine.edge.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-edge-helix-amd64 | ||
| - ${{ if or(ne(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - (Alpine.321.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
| - (Alpine.322.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-amd64 | ||
|
|
||
| # Linux musl arm64 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_arm64') }}: | ||
| - ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - (Alpine.321.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-arm64v8 | ||
| - (Alpine.322.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-arm64v8 | ||
|
|
||
| # Linux x64 | ||
| - ${{ if eq(parameters.platform, 'linux_x64') }}: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see the alpine edge running in outer loop, so this condition is probably not right.
@jkoritzinsky Do you happen to know how to check for main vs. servicing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on checking. I did not do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about doing the same thing for Fedora, just testing it in
main. It would be nice to just have one fast-moving distro in servicing to maintain. We get significant RHEL-family coverage from CentOS Stream and Alma Linux. I think that + Fedora inmainis a good model.