-
Notifications
You must be signed in to change notification settings - Fork 5k
Update build and test images to Alpine 3.22 #116167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the build and test images to Alpine 3.22 while commenting out the Alpine Edge builds for non‑main branches. Key changes include:
- Updating image tags from alpine-3.21 to alpine-3.22 in various pipeline YAML files.
- Commenting out the Alpine Edge build references to restrict their use to the main branch.
- Ensuring consistency across library, installer, coreclr templates, and common pipeline resource configurations.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
eng/pipelines/libraries/helix-queues-setup.yml | Updated Alpine image version and commented out Alpine Edge. |
eng/pipelines/installer/helix-queues-setup.yml | Updated the Alpine image version for the installer pipeline. |
eng/pipelines/coreclr/templates/helix-queues-setup.yml | Updated image tags for both public and internal pipelines. |
eng/pipelines/common/templates/pipeline-with-resources.yml | Updated Alpine image version in common pipeline resources. |
Comments suppressed due to low confidence (5)
eng/pipelines/libraries/helix-queues-setup.yml:40
- Confirm that the Alpine Edge build references remain commented out for non‑main branches as intended.
# Alpine edge builds should only be used in main
eng/pipelines/libraries/helix-queues-setup.yml:44
- Verify that the updated Alpine 3.22 image tag is supported by all dependent build tools and environments.
- (Alpine.322.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-amd64
eng/pipelines/installer/helix-queues-setup.yml:36
- Ensure that the update to Alpine 3.22 in the installer pipeline is validated within the AzureLinux environment.
- (Alpine.322.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-amd64
eng/pipelines/coreclr/templates/helix-queues-setup.yml:80
- Confirm that both public and internal pipeline configurations intentionally use the Alpine 3.22 image tag.
- (Alpine.322.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.22-helix-amd64
eng/pipelines/common/templates/pipeline-with-resources.yml:70
- Check that the update to Alpine 3.22 in the common pipeline resource template is compatible with the overall pipeline configuration.
image: mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.22-amd64
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: Jan Kotas <[email protected]>
Looks like this change came out clean. Just need an approval now. |
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
Good call. Running outer loop occurred to me. Will do that next time. BA is now green. |
- ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
- (Alpine.edge.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-edge-helix-amd64 | ||
# Alpine edge builds should only be used in main | ||
- ${{ if eq(contains(coalesce(variables['System.PullRequest.TargetBranch'], variables['Build.SourceBranch'], ''), 'main'), 'true') }}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see the alpine edge running in outer loop, so this condition is probably not right.
@jkoritzinsky Do you happen to know how to check for main vs. servicing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on checking. I did not do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about doing the same thing for Fedora, just testing it in main
. It would be nice to just have one fast-moving distro in servicing to maintain. We get significant RHEL-family coverage from CentOS Stream and Alma Linux. I think that + Fedora in main
is a good model.
main
. Will bring that back after the RC snap and when preparing for Alpine 3.23 becomes relevant.Related: