Skip to content

Add Microsoft.Build.Tasks.Core dependency management via Version.Details.xml #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikolaMilosavljevic merged 5 commits into from
Dec 10, 2025
Merged

Add Microsoft.Build.Tasks.Core dependency management via Version.Details.xml #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a32811f
Initial plan
Copilot Dec 3, 2025
fe2b60e
Add Microsoft.Build.Tasks.Core to Version.Details.xml for automated u…
Copilot Dec 3, 2025
3356b83
Update Directory.Packages.props to use MicrosoftBuildTasksCoreVersion…
Copilot Dec 3, 2025
e4837c4
Move MicrosoftBuildTasksCoreVersion property from Version.Details.pro…
Copilot Dec 9, 2025
80252f3
Move MicrosoftBuildTasksCoreVersion property back to Version.Details.…
Copilot Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<ItemGroup>
<!-- MSBuild dependencies -->
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.10.46" />
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" />

<!-- Runtime dependencies -->
<PackageVersion Include="System.Security.Cryptography.Xml" Version="8.0.0" />
Expand All @@ -24,7 +24,6 @@

<!-- Overrides needed until https://github.com/dotnet/source-build/issues/4467 is implemented. -->
<ItemGroup>
<PackageVersion Update="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" Condition="'$(MicrosoftBuildTasksCoreVersion)' != ''" />
<PackageVersion Update="System.Security.Cryptography.Xml" Version="$(SystemSecurityCryptographyXmlVersion)" Condition="'$(SystemSecurityCryptographyXmlVersion)' != ''" />
<PackageVersion Update="System.Text.Json" Version="$(SystemTextJsonVersion)" Condition="'$(SystemTextJsonVersion)' != ''" />
</ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions eng/Version.Details.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ This file should be imported by eng/Versions.props
<PropertyGroup>
<!-- dotnet/dotnet dependencies -->
<MicrosoftDotNetArcadeSdkPackageVersion>10.0.0-beta.25601.102</MicrosoftDotNetArcadeSdkPackageVersion>
<MicrosoftBuildTasksCoreVersion>17.10.46</MicrosoftBuildTasksCoreVersion>
</PropertyGroup>
<!--Property group for alternate package version names-->
<PropertyGroup>
Expand Down
4 changes: 4 additions & 0 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<Dependencies>
<Source Uri="https://github.com/dotnet/dotnet" Mapping="deployment-tools" Sha="f2d1a92c2429848e41e78af560381a597f933090" BarId="292766" />
<ProductDependencies>
<Dependency Name="Microsoft.Build.Tasks.Core" Version="17.10.46">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>f2d1a92c2429848e41e78af560381a597f933090</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.25601.102">
Expand Down