Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

MSBuild dependency version is currently hardcoded in Directory.Packages.props and requires manual updates. This PR adds centralized version management for the MSBuild package via darc automation.

Changes

  • eng/Version.Details.xml: Added Microsoft.Build.Tasks.Core dependency under ProductDependencies
  • eng/Version.Details.props: Added MicrosoftBuildTasksCoreVersion property for darc to manage
  • Directory.Packages.props: Updated to use $(MicrosoftBuildTasksCoreVersion) property directly in the PackageVersion entry and removed the redundant override

Note: The property is defined in Version.Details.props where darc will automatically update it during dependency flows from the appropriate MSBuild repository.

Original prompt

This section details on the original issue you should resolve

<issue_title>Automate the updates of MSBuild dependencies</issue_title>
<issue_description>Currently, MSBuild dependency needs to be updated manually by revving the version specified here:

<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.10.29" />

Consider implementing an automated process. Perhaps darc subscription can be utilized.</issue_description>

<agent_instructions>Please add the package dependency to eng/Version.Details.xml.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@NikolaMilosavljevic [Triage] @NikolaMilosavljevic please fix.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Automate updates of MSBuild dependencies Add Microsoft.Build.Tasks.Core to Version.Details.xml for automated updates Dec 3, 2025
@NikolaMilosavljevic
Copy link
Member

@copilot please update Directory.Packages.props to utilize the new property in the explicit PackageVersion entry for this package -

<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.10.29" />

… property directly

Co-authored-by: NikolaMilosavljevic <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 3, 2025

@copilot please update Directory.Packages.props to utilize the new property in the explicit PackageVersion entry for this package - https://github.com/dotnet/deployment-tools/blob/84ccc0553245e903...

Done in 3356b83. Updated line 12 to use $(MicrosoftBuildTasksCoreVersion) directly and removed the now-redundant override entry.

@NikolaMilosavljevic
Copy link
Member

Closing as we do not want to flow this package updates from VMR. Will create a new PR with correct flow from the appropriate MSBuild repo.

@NikolaMilosavljevic
Copy link
Member

@copilot move the new property from Version.Details.props to Versions.props

…ps to Versions.props

Co-authored-by: NikolaMilosavljevic <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 9, 2025

@copilot move the new property from Version.Details.props to Versions.props

Done in e4837c4. Moved the MicrosoftBuildTasksCoreVersion property from Version.Details.props to Versions.props.

Copilot AI changed the title Add Microsoft.Build.Tasks.Core to Version.Details.xml for automated updates Add Microsoft.Build.Tasks.Core dependency management via Versions.props Dec 9, 2025
@NikolaMilosavljevic NikolaMilosavljevic marked this pull request as ready for review December 9, 2025 17:19
@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner December 9, 2025 17:19
<StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion>
<DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind>
<!-- MSBuild dependency version -->
<MicrosoftBuildTasksCoreVersion>17.10.46</MicrosoftBuildTasksCoreVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a darc/Version.Details.xml dependency, this property should be defined in Version.Details.props. This is relatively new. This is where all darc will define/update the property on dependency flows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see - I thought that those are for VMR flow only.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot move the new property back to eng/Version.Details.props file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 80252f3. Moved the MicrosoftBuildTasksCoreVersion property back to Version.Details.props where darc will manage it.

Copilot AI changed the title Add Microsoft.Build.Tasks.Core dependency management via Versions.props Add Microsoft.Build.Tasks.Core dependency management via Version.Details.xml Dec 10, 2025
@NikolaMilosavljevic NikolaMilosavljevic merged commit 6ebef72 into main Dec 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate the updates of MSBuild dependencies

3 participants