-
Notifications
You must be signed in to change notification settings - Fork 65
Add Microsoft.Build.Tasks.Core dependency management via Version.Details.xml #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft.Build.Tasks.Core dependency management via Version.Details.xml #521
Conversation
…pdates Co-authored-by: NikolaMilosavljevic <[email protected]>
|
@copilot please update deployment-tools/Directory.Packages.props Line 12 in 84ccc05
|
… property directly Co-authored-by: NikolaMilosavljevic <[email protected]>
Done in 3356b83. Updated line 12 to use |
|
Closing as we do not want to flow this package updates from VMR. Will create a new PR with correct flow from the appropriate MSBuild repo. |
|
@copilot move the new property from |
…ps to Versions.props Co-authored-by: NikolaMilosavljevic <[email protected]>
eng/Versions.props
Outdated
| <StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion> | ||
| <DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind> | ||
| <!-- MSBuild dependency version --> | ||
| <MicrosoftBuildTasksCoreVersion>17.10.46</MicrosoftBuildTasksCoreVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this is a darc/Version.Details.xml dependency, this property should be defined in Version.Details.props. This is relatively new. This is where all darc will define/update the property on dependency flows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see - I thought that those are for VMR flow only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot move the new property back to eng/Version.Details.props file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 80252f3. Moved the MicrosoftBuildTasksCoreVersion property back to Version.Details.props where darc will manage it.
…props Co-authored-by: NikolaMilosavljevic <[email protected]>
MSBuild dependency version is currently hardcoded in
Directory.Packages.propsand requires manual updates. This PR adds centralized version management for the MSBuild package via darc automation.Changes
eng/Version.Details.xml: AddedMicrosoft.Build.Tasks.Coredependency underProductDependencieseng/Version.Details.props: AddedMicrosoftBuildTasksCoreVersionproperty for darc to manageDirectory.Packages.props: Updated to use$(MicrosoftBuildTasksCoreVersion)property directly in thePackageVersionentry and removed the redundant overrideNote: The property is defined in
Version.Details.propswhere darc will automatically update it during dependency flows from the appropriate MSBuild repository.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.