-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Build Windows local test job in official builds #61519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Windows Local Development job to the official builds to enable building templates in the internal project and tracking them via CG. The key changes include updating the build step to use a PowerShell script instead of a CMD script and adding additional build parameters.
- Replaces build.cmd with build.ps1 and adds the "-WarnAsError:false" flag.
- Adds the "-bl" argument to the test execution block.
Comments suppressed due to low confidence (2)
.azure/pipelines/ci.yml:661
- [nitpick] The purpose of the '-bl' flag is not immediately clear. Consider adding an inline comment or using a more descriptive flag name to clarify its intent.
-bl
.azure/pipelines/ci.yml:647
- The new build step uses a PowerShell script with a quoted argument '-WarnAsError:false'. Please verify that the quotes are required and that the script correctly interprets the flag. If the script expects a boolean value, consider passing it without quotes or using an assignment format (for example, -WarnAsError=$false).
- powershell: ./eng/build.ps1 -all -noBuildJava -noBuildNodeJS "-WarnAsError:false"
This is working now - components like |
Allows us to build our templates in the internal project, so that they can be tracked by CG. Fixes #61518.
Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2688844&view=results