Skip to content

[release/6.0] Try skipping tests with Japanese chars #47560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023
Merged

[release/6.0] Try skipping tests with Japanese chars #47560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebe5614
Try skipping tests with japanese chars
wtgodbe Apr 4, 2023
4e8c55b
Add Issue
wtgodbe Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/SignalR/common/SignalR.Common/test/Internal/Protocol/Utf8BufferTextWriterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Text;
using Microsoft.AspNetCore.Internal;
using Microsoft.AspNetCore.SignalR.Internal;
using Microsoft.AspNetCore.Testing;
using Xunit;

namespace Microsoft.AspNetCore.SignalR.Common.Tests.Internal.Protocol
Expand Down Expand Up @@ -244,7 +245,8 @@ public void GetAndReturnCachedBufferTextWriter()
Assert.Same(textWriter1, textWriter2);
}

[Fact]
[ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47566", Queues = "All.OSX")]
public void WriteMultiByteCharactersToSmallBuffers()
{
// Test string breakdown (char => UTF-8 hex values):
Expand Down Expand Up @@ -306,7 +308,8 @@ public static IEnumerable<object[]> CharAndSegmentSizes
}
}

[Theory]
[ConditionalTheory]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47566", Queues = "All.OSX")]
[MemberData(nameof(CharAndSegmentSizes))]
public void WriteUnicodeStringAndCharsWithVaryingSegmentSizes(char singleChar, int segmentSize)
{
Expand Down