Skip to content

[release/6.0] Try skipping tests with Japanese chars #47560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2023
Merged

[release/6.0] Try skipping tests with Japanese chars #47560

merged 2 commits into from
Apr 6, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 4, 2023

Seeing if this fixes the issue seen in #47545 (comment)

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Apr 4, 2023
@ghost ghost added this to the 6.0.x milestone Apr 4, 2023
@wtgodbe wtgodbe marked this pull request as draft April 4, 2023 17:11
@ghost
Copy link

ghost commented Apr 4, 2023

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 4, 2023
@wtgodbe wtgodbe mentioned this pull request Apr 4, 2023
Merged
11 tasks
@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 4, 2023 •
edited
Loading

Passed on macOS-11.6.7, trying again

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@BrennanConroy
Copy link
Member

11.6.8 passed: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-47560-merge-13ae8898bf4848d8b4/Microsoft.AspNetCore.SignalR.Common.Tests--net6.0/1/console.e00fc879.log?helixlogtype=result

@wtgodbe wtgodbe marked this pull request as ready for review April 4, 2023 20:57
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Apr 4, 2023
@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 4, 2023

@BrennanConroy could you review?

@wtgodbe wtgodbe enabled auto-merge (squash) April 4, 2023 20:59
@wtgodbe wtgodbe changed the title Try skipping tests with japanese chars Try skipping tests with Japanese chars Apr 4, 2023
@wtgodbe wtgodbe changed the title Try skipping tests with Japanese chars [release/6.0] Try skipping tests with Japanese chars Apr 4, 2023
@wtgodbe wtgodbe merged commit 8b458e2 into dotnet:release/6.0 Apr 6, 2023
@ghost ghost modified the milestones: 6.0.x, 6.0.17 Apr 6, 2023
@wtgodbe wtgodbe deleted the wtgodbe/SkipSomeTests branch April 6, 2023 18:57
@wtgodbe wtgodbe restored the wtgodbe/SkipSomeTests branch November 15, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-signalr Includes: SignalR clients and servers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
6.0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @BrennanConroy @sebastienros