-
Notifications
You must be signed in to change notification settings - Fork 541
[native] Improvements to the internal timing infrastructure #9993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6095cbe
to
f7b2f17
Compare
f7b2f17
to
5f8341c
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
f663a34
to
7823b27
Compare
@@ -57,6 +60,7 @@ namespace xamarin::android { | |||
static inline constexpr std::string_view DEBUG_MONO_SOFT_BREAKPOINTS { "debug.mono.soft_breakpoints" }; | |||
static inline constexpr std::string_view DEBUG_MONO_TRACE_PROPERTY { "debug.mono.trace" }; | |||
static inline constexpr std::string_view DEBUG_MONO_WREF_PROPERTY { "debug.mono.wref" }; | |||
static constexpr std::string_view DEBUG_MONO_TIMING { "debug.mono.timing" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ongoing question, which shouldn't be addressed here, is "should CoreCLR and MonoVM use the same set of properties?"
For example, b217dca parses a debug.dotnet.log
system property instead of debug.mono.log
, specifically because NativeAOT does not support the "full" set of values & semantics that debug.mono.log
provides.
Perhaps "timing" is identical, but this is something to (re)consider in the future.
std::chrono
)sequence ID. Instead, calls to start and end events are now using a thread-local
stack.
time_call
timing function.