Use bare pointer instead of unique_ptr, simpler and faster (slightly)

Author: grendello

src/native/common/include/runtime-base/timing-internal.hh

@@ -65,7 +65,7 @@ namespace xamarin::android {
 		time_point                   start;
 		time_point                   end;
 		TimingEventKind              kind;
-		std::unique_ptr<std::string> more_info{};
+		std::string                 *more_info = nullptr;
 	};
 
 	class FastTiming;
@@ -220,7 +220,7 @@ namespace xamarin::android {
 			message.append ("] "sv);
 
 			append_event_kind_description (event.kind, message);
-			if (event.more_info && !event.more_info->empty ()) {
+			if (event.more_info != nullptr && !event.more_info->empty ()) {
 				message.append (event.more_info->c_str (), event.more_info->length ());
 			}
 
@@ -255,7 +255,7 @@ namespace xamarin::android {
 				return;
 			}
 
-			if (skip_log_if_more_info_missing && (!event.more_info || event.more_info->empty ())) {
+			if (skip_log_if_more_info_missing && (event.more_info == nullptr || event.more_info->empty ())) {
 				return;
 			}
 
@@ -301,9 +301,7 @@ namespace xamarin::android {
 			ev.start = get_time ();
 			ev.kind = kind;
 			ev.before_managed = MonodroidState::is_startup_in_progress ();
-			if (ev.more_info) {
-				ev.more_info.reset ();
-			}
+			ev.more_info = nullptr;
 			log_warn (LOG_DEFAULT, "#grendel 5.011");
 		}
 
@@ -340,7 +338,7 @@ namespace xamarin::android {
 				return;
 			}
 
-			events[*index].more_info = std::make_unique<std::string> (str.get (), str.length ());
+			events[*index].more_info = new std::string (str.get (), str.length ());
 			log (events[*index], false /* skip_log_if_more_info_missing */);
 		}
 
@@ -353,7 +351,7 @@ namespace xamarin::android {
 				return;
 			}
 
-			events[*index].more_info = std::make_unique<std::string> (str);
+			events[*index].more_info = new std::string (str);
 			log (events[*index], false /* skip_log_if_more_info_missing */);
 		}
 
@@ -366,7 +364,7 @@ namespace xamarin::android {
 				return;
 			}
 
-			events[*index].more_info = std::make_unique<std::string> (str);
+			events[*index].more_info = new std::string (str);
 			log (events[*index], false /* skip_log_if_more_info_missing */);
 		}
 

src/native/common/runtime-base/timing-internal.cc

@@ -1,6 +1,5 @@
 #include <chrono>
 
-//#include <xamarin-app.hh>
 #include <runtime-base/android-system.hh>
 #include <runtime-base/startup-aware-lock.hh>
 #include <runtime-base/strings.hh>