Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct iard.md #32595

Closed
wants to merge 3 commits into from
Closed

Correct iard.md #32595

wants to merge 3 commits into from

Conversation

tonyhallett
Copy link

@tonyhallett tonyhallett commented May 17, 2024

Remove all references to the MinimumAgePolicyProvider that is not used when using IAuthorizationRequirementData.

The middleware constructs a policy adding the requirements from IAuthorizationRequirementData.GetRequirements

https://github.com/dotnet/aspnetcore/blob/82b0fc9f43ae2bd50fb95f427116efc2f6f094df/src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs#L130


Internal previews

📄 File 🔗 Preview link
aspnetcore/security/authorization/iard.md aspnetcore/security/authorization/iard

Remove all references to the MinimumAgePolicyProvider that is not used when using IAuthorizationRequirementData.

The middleware constructs a policy adding the requirements from IAuthorizationRequirementData.GetRequirements

https://github.com/dotnet/aspnetcore/blob/82b0fc9f43ae2bd50fb95f427116efc2f6f094df/src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs#L130
@Rick-Anderson Rick-Anderson self-assigned this May 22, 2024
@Rick-Anderson
Copy link
Contributor

@adityamandaleeka can you assign someone to review this?

@guardrex
Copy link
Collaborator

guardrex commented Mar 25, 2025

@Rick-Anderson ... I don't understand why we'd remove this because this is how to set up a custom IAuthorizationPolicyProvider.

Note in passing that the docs could just point to the PU's demo at ...

https://github.com/dotnet/aspnetcore/tree/main/src/Security/samples/CustomPolicyProvider

... and shed the sample that the docs maintain (in the samples repo). The PU's sample is more likely to be kept up to date because they have it wired to their tests. I recommend at least closing this and asking for an issue.

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson ... I don't understand why we'd remove this because this is how to set up a custom IAuthorizationPolicyProvider.

Note in passing that the docs could just point to the PU's demo at ...

https://github.com/dotnet/aspnetcore/tree/main/src/Security/samples/CustomPolicyProvider

... and shed the sample that the docs maintain (in the samples repo). The PU's sample is more likely to be kept up to date because they have it wired to their tests. I recommend at least closing this and asking for an issue.

#35045

@Rick-Anderson
Copy link
Contributor

@tonyhallett any chance you could do #35045
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants