Skip to content

민경준 2주차 과제 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/main/java/doit/apihw/api/controller/MemberController.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,10 @@
import doit.apihw.api.controller.dto.AuthPasswordChangeRequest;
import doit.apihw.api.controller.dto.MemberResponse;
import doit.apihw.api.service.MemberService;
import java.util.List;
import lombok.RequiredArgsConstructor;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;
import org.springframework.web.bind.annotation.*;

import java.util.List;

@RestController
@RequiredArgsConstructor
Expand Down Expand Up @@ -50,6 +46,10 @@ public void changePassword(@PathVariable Long memberId, @RequestBody AuthPasswor
memberService.changePassword(memberId, request);
}

// TODO : 자유 주제로 API를 추가로 구현해보세요.
// TODO : 자유 주제로 API를 추가로 구현해보세요. => 관리자가 회원 관리하기 위한 memberId 기준으로 정렬된 list
@PostMapping("/members/loginIdAsc")
public List<MemberResponse> searchMembersByIdAsc(@RequestParam String memberId) {
return memberService.AllMembersWithLoginIdDesc(memberId);
}
Comment on lines +50 to +53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 잘 작성해주신 것 같습니다.
다만 Post 요청은 보통 데이터를 추가할 때, 또는 변경할 때 사용하므로
GET 요청으로 하는게 조금 더 의미에 와닿을 것 같습니다.

Suggested change
@PostMapping("/members/loginIdAsc")
public List<MemberResponse> searchMembersByIdAsc(@RequestParam String memberId) {
return memberService.AllMembersWithLoginIdDesc(memberId);
}
@GetMapping("/members/loginIdAsc")
public List<MemberResponse> searchMembersByIdAsc(@RequestParam String memberId) {
return memberService.AllMembersWithLoginIdDesc(memberId);
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 지적 감사합니다!!


}
11 changes: 9 additions & 2 deletions src/main/java/doit/apihw/api/service/AuthService.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@

import doit.apihw.api.controller.dto.AuthLoginRequest;
import doit.apihw.api.controller.dto.AuthLoginResponse;
import doit.apihw.api.controller.dto.AuthPasswordChangeRequest;
import doit.apihw.api.controller.dto.AuthSignUpRequest;
import doit.apihw.domain.member.Member;
import doit.apihw.domain.member.MemberRepository;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.web.bind.annotation.RestController;

@RestController
@Service
@RequiredArgsConstructor
public class AuthService {

Expand Down Expand Up @@ -52,11 +53,17 @@ public AuthLoginResponse signUp(AuthSignUpRequest request) {
// TODO : 로그인을 진행한다.
public AuthLoginResponse login(AuthLoginRequest request) {
// DB에서 memberLoginId와 memberPassword를 조회하여 일치하는 회원이 있는지 확인한다.
Member member = memberRepository.findMemberByMemberLoginIdAndMemberPassword(request.getMemberLoginId(), request.getMemberPassword());

// 만약 일치하는 회원이 없다면, IllegalArgumentException을 발생시킨다.
if(member == null) {
throw new IllegalArgumentException("일치하는 회원이 존재하지 않습니다.");
}

// 일치하는 회원이 있다면, MemberResponse로 변환하여 반환한다.
return null;
else {
return AuthLoginResponse.from(member);
}
}


Expand Down
57 changes: 52 additions & 5 deletions src/main/java/doit/apihw/api/service/MemberService.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
import doit.apihw.api.controller.dto.MemberResponse;
import doit.apihw.domain.member.Member;
import doit.apihw.domain.member.MemberRepository;
import java.time.LocalDate;
import java.util.List;
import java.util.Optional;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;

import java.util.ArrayList;
import java.util.List;
import java.util.Optional;

@Service
@RequiredArgsConstructor
public class MemberService {
Expand All @@ -31,26 +32,72 @@ public MemberResponse findOneMember(Long memberId) {
// TODO : 전체 회원 정보를 조회한다.
public List<MemberResponse> findAllMembers() {
// DB에서 전체 회원 정보를 조회한다.
List<MemberResponse> members = new ArrayList<>();

List<Member> result = memberRepository.findAll();

// 조회된 회원 정보를 List<MemberResponse>로 변환하여 반환한다.
return null;
for(Member member: result) {
MemberResponse response = MemberResponse.builder()
.memberName(member.getMemberName())
.memberBirthday(member.getMemberBirthday())
.memberLoginId(member.getMemberLoginId())
.build();
members.add(response);
}
return members;
}

// TODO : 회원 이름으로 회원 정보를 조회한다.
public List<MemberResponse> searchMembersWithName(String memberName) {
// DB에서 memberName에 해당하는 회원 정보를 조회한다.
List<MemberResponse> member = new ArrayList<>();

List<Member> result = memberRepository.findMemberByMemberName(memberName);

// 조회된 회원 정보를 List<MemberResponse>로 변환하여 반환한다.
return null;
for(Member memberInfo: result) {
MemberResponse response = MemberResponse.builder()
.memberName(memberInfo.getMemberName())
.memberBirthday(memberInfo.getMemberBirthday())
.memberLoginId(memberInfo.getMemberLoginId())
.build();
member.add(response);
}
return member;
}

// TODO : 회원 비밀번호를 변경한다.
public void changePassword(Long memberId, AuthPasswordChangeRequest request) {
// DB에서 memberId에 해당하는 회원 정보를 조회하고, 존재하지 않는다면 IllegalArgumentException을 발생시킨다.
Member member = memberRepository.findByMemberLoginId(memberId.toString());
if(member == null) {
throw new IllegalArgumentException("존재하지 않는 회원 정보입니다.");
}

// 조회된 회원 정보의 비밀번호를 변경한다. ( request.getNewPassword()를 이용하여 변경한다. )
member.changePassword(request.getOldPassword(), request.getNewPassword());

// 변경된 회원 정보를 DB에 저장한다.
memberRepository.save(member);
}

public List<MemberResponse> AllMembersWithLoginIdDesc(String Id) {

List<MemberResponse> members = new ArrayList<>();

List<Member> sortedMembers = memberRepository.findAllByOrderByMemberLoginIdDesc();

for(Member member: sortedMembers) {
MemberResponse response = MemberResponse.builder()
.memberName(member.getMemberName())
.memberBirthday(member.getMemberBirthday())
.memberLoginId(member.getMemberLoginId())
.build();
members.add(response);
}

return members;
}

}
8 changes: 8 additions & 0 deletions src/main/java/doit/apihw/domain/member/MemberRepository.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
package doit.apihw.domain.member;

import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.stereotype.Repository;

import java.util.List;

@Repository
public interface MemberRepository extends JpaRepository<Member, Long> {
Member findByMemberLoginId(String memberLoginId);
// TODO : 회원 이름으로 회원 정보를 조회한다.
List<Member> findMemberByMemberName(String memberName);

// TODO : 회원 로그인 ID와 비밀번호로 회원 정보를 조회한다.
Member findMemberByMemberLoginIdAndMemberPassword(String memberName, String memberPassword);

List<Member> findAllByOrderByMemberLoginIdDesc();

}