민경준 2주차 과제 #1
Open
민경준 2주차 과제 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjunhub
reviewed
Oct 9, 2024
Comment on lines
+50
to
+53
| @PostMapping("/members/loginIdAsc") | ||
| public List<MemberResponse> searchMembersByIdAsc(@RequestParam String memberId) { | ||
| return memberService.AllMembersWithLoginIdDesc(memberId); | ||
| } |
There was a problem hiding this comment.
코드 잘 작성해주신 것 같습니다.
다만 Post 요청은 보통 데이터를 추가할 때, 또는 변경할 때 사용하므로
GET 요청으로 하는게 조금 더 의미에 와닿을 것 같습니다.
Suggested change
| @PostMapping("/members/loginIdAsc") | |
| public List<MemberResponse> searchMembersByIdAsc(@RequestParam String memberId) { | |
| return memberService.AllMembersWithLoginIdDesc(memberId); | |
| } | |
| @GetMapping("/members/loginIdAsc") | |
| public List<MemberResponse> searchMembersByIdAsc(@RequestParam String memberId) { | |
| return memberService.AllMembersWithLoginIdDesc(memberId); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
회원을 등록하지 않고 비밀번호 변경을 시도한다.(오류 발생)
