add private function for initating DO

[yucongalicechen]

addressing #80

[sbillinge]

it still seems a bit hard to read. Also the numbers in the yarray are fairly irrational

[sbillinge]

if you pass everything in we don't gain much. Are there cases where you want to vary name="test", scat_quantity="x-ray" etc?

I would make yarray a required arg too to make the code more readable.

Also, is it necessary to pass in mocker? It may be, but if not I don't think it adds much syntatically.

[yucongalicechen]

Yeah I couldn't find prettier numbers for the yarrays.. they all seem a bit messy.
The name and scat_quantity are for the absorption correction DOs.
I can remove the mocker, it's not needed there.

[sbillinge]

I gave some. uncorrected [2,2,2] correction [0.5,0.5,0.5], corrected [1,1,1]

…

On Thu, Jun 20, 2024 at 4:36 PM Yucong (Alice) Chen < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/diffpy/labpdfproc/tests/test_functions.py <#81 (comment)> : > @@ -56,27 +56,29 @@ def test_set_muls_at_angle(inputs, expected): assert actual_muls_sorted == pytest.approx(expected_muls_sorted, rel=1e-4, abs=1e-6) -def test_compute_cve(mocker): +def _instantiate_test_do(mocker, yarray, name="test", scat_quantity="x-ray"): Yeah I couldn't find prettier numbers for the yarrays.. they all seem a bit messy. The name and scat_quantity are for the absorption correction DOs. I can remove the mocker, it's not needed there. — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAOWUN6GFIZFWDJLWDVSNLZIM4MNAVCNFSM6AAAAABJUNK43WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZRGMYDMMJSHA> . You are receiving this because you commented.Message ID: <diffpy/diffpy. ***@***.***>

-- Simon Billinge Professor, Department of Applied Physics and Applied Mathematics Columbia University

[yucongalicechen]

I added tests for apply_corr here too. It seems that I can write another private function for the setup to simplify (mocker, input pattern, etc.)..?