tests for apply_corr #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbillinge
reviewed
Jun 20, 2024
| @@ -80,3 +80,39 @@ def test_compute_cve(mocker): | |||
| scat_quantity="cve", | |||
| ) | |||
| assert actual_abdo == expected_abdo | |||
|
|
|||
|
|
|||
| def test_apply_corr(mocker): | |||
There was a problem hiding this comment.
this test is probably correct but hard to follow.
- there is a lot of duplicated code instantiating the DO's so maybe make a helper function called something like
_instantiate_test_do(yarray)and just call that with only the y-array as input - maybe make the inputs easier to understand, so input y-array is [2., 2., 2.] and correction is [0.5, 0.5, 0.5] and so expected is a do with yarray [1., 1., 1.].
Would these make it easier to read?
If you make that wrapper function, on a separate PR we can maybe clean up some of the other tests as well.
There was a problem hiding this comment.
Sounds good, I'll do that
|
closed by #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19
@sbillinge I saw that you assigned this to yourself but I thought I could just do it conveniently by following the tests for compute_cve