feat: migrate external argo cd application

Wire.go

@@ -102,14 +102,14 @@ import (
 	appWorkflow2 "github.com/devtron-labs/devtron/internal/sql/repository/appWorkflow"
 	"github.com/devtron-labs/devtron/internal/sql/repository/bulkUpdate"
 	"github.com/devtron-labs/devtron/internal/sql/repository/chartConfig"
-	"github.com/devtron-labs/devtron/internal/sql/repository/deploymentConfig"
 	dockerRegistryRepository "github.com/devtron-labs/devtron/internal/sql/repository/dockerRegistry"
 	"github.com/devtron-labs/devtron/internal/sql/repository/helper"
 	repository8 "github.com/devtron-labs/devtron/internal/sql/repository/imageTagging"
 	"github.com/devtron-labs/devtron/internal/sql/repository/pipelineConfig"
 	resourceGroup "github.com/devtron-labs/devtron/internal/sql/repository/resourceGroup"
 	"github.com/devtron-labs/devtron/internal/util"
 	"github.com/devtron-labs/devtron/pkg/app"
+	read4 "github.com/devtron-labs/devtron/pkg/app/appDetails/read"
 	"github.com/devtron-labs/devtron/pkg/app/dbMigration"
 	"github.com/devtron-labs/devtron/pkg/app/status"
 	"github.com/devtron-labs/devtron/pkg/appClone"
@@ -128,6 +128,7 @@ import (
 	"github.com/devtron-labs/devtron/pkg/bulkAction/service"
 	"github.com/devtron-labs/devtron/pkg/chart"
 	"github.com/devtron-labs/devtron/pkg/chart/gitOpsConfig"
+	read2 "github.com/devtron-labs/devtron/pkg/chart/read"
 	chartRepoRepository "github.com/devtron-labs/devtron/pkg/chartRepo/repository"
 	"github.com/devtron-labs/devtron/pkg/commonService"
 	"github.com/devtron-labs/devtron/pkg/config"
@@ -357,6 +358,8 @@ func InitializeApp() (*App, error) {
 		wire.Bind(new(gitOpsConfig.DevtronAppGitOpConfigService), new(*gitOpsConfig.DevtronAppGitOpConfigServiceImpl)),
 		chart.NewChartServiceImpl,
 		wire.Bind(new(chart.ChartService), new(*chart.ChartServiceImpl)),
+		read2.NewChartReadServiceImpl,
+		wire.Bind(new(read2.ChartReadService), new(*read2.ChartReadServiceImpl)),
 		service.NewBulkUpdateServiceImpl,
 		wire.Bind(new(service.BulkUpdateService), new(*service.BulkUpdateServiceImpl)),
 
@@ -375,6 +378,10 @@ func InitializeApp() (*App, error) {
 		wire.Bind(new(appList.AppListingRouter), new(*appList.AppListingRouterImpl)),
 		appList2.NewAppListingRestHandlerImpl,
 		wire.Bind(new(appList2.AppListingRestHandler), new(*appList2.AppListingRestHandlerImpl)),
+
+		read4.NewAppDetailsReadServiceImpl,
+		wire.Bind(new(read4.AppDetailsReadService), new(*read4.AppDetailsReadServiceImpl)),
+
 		app.NewAppListingServiceImpl,
 		wire.Bind(new(app.AppListingService), new(*app.AppListingServiceImpl)),
 		repository.NewAppListingRepositoryImpl,
@@ -622,6 +629,7 @@ func InitializeApp() (*App, error) {
 		repository9.NewClusterInstalledAppsRepositoryImpl,
 		wire.Bind(new(repository9.ClusterInstalledAppsRepository), new(*repository9.ClusterInstalledAppsRepositoryImpl)),
 
+		commonService.NewCommonBaseServiceImpl,
 		commonService.NewCommonServiceImpl,
 		wire.Bind(new(commonService.CommonService), new(*commonService.CommonServiceImpl)),
 
@@ -659,8 +667,8 @@ func InitializeApp() (*App, error) {
 
 		router.NewCommonRouterImpl,
 		wire.Bind(new(router.CommonRouter), new(*router.CommonRouterImpl)),
-		restHandler.NewCommonRestHanlderImpl,
-		wire.Bind(new(restHandler.CommonRestHanlder), new(*restHandler.CommonRestHanlderImpl)),
+		restHandler.NewCommonRestHandlerImpl,
+		wire.Bind(new(restHandler.CommonRestHandler), new(*restHandler.CommonRestHandlerImpl)),
 
 		router.NewScopedVariableRouterImpl,
 		wire.Bind(new(router.ScopedVariableRouter), new(*router.ScopedVariableRouterImpl)),
@@ -941,11 +949,7 @@ func InitializeApp() (*App, error) {
 		cel.NewCELServiceImpl,
 		wire.Bind(new(cel.EvaluatorService), new(*cel.EvaluatorServiceImpl)),
 
-		deploymentConfig.NewRepositoryImpl,
-		wire.Bind(new(deploymentConfig.Repository), new(*deploymentConfig.RepositoryImpl)),
-
-		common.NewDeploymentConfigServiceImpl,
-		wire.Bind(new(common.DeploymentConfigService), new(*common.DeploymentConfigServiceImpl)),
+		common.WireSet,
 
 		repoCredsK8sClient.NewRepositoryCredsK8sClientImpl,
 		wire.Bind(new(repoCredsK8sClient.RepositoryCredsK8sClient), new(*repoCredsK8sClient.RepositoryCredsK8sClientImpl)),

WiringNilCheck.go

@@ -114,6 +114,8 @@ func skipUnnecessaryFieldsForCheck(fieldName, valName string) bool {
 		"modulecronserviceimpl":        {"cron"},
 		"oteltracingserviceimpl":       {"traceprovider"},
 		"terminalaccessrepositoryimpl": {"templatescache"},
+		"grpcapiclientimpl":            {"serviceclient"},
+		"serverenvconfig":              {"errorencounteredongettingdevtronhelmrelease"},
 	}
 	if _, ok := fieldAndValName[valName]; ok {
 		for _, ignoreFieldName := range fieldAndValName[valName] {

api/argoApplication/ArgoApplicationRestHandler.go

@@ -17,6 +17,7 @@
 package argoApplication
 
 import (
+	"context"
 	"errors"
 	"github.com/devtron-labs/devtron/api/restHandler/common"
 	"github.com/devtron-labs/devtron/pkg/argoApplication"
@@ -89,6 +90,9 @@ func (handler *ArgoApplicationRestHandlerImpl) GetApplicationDetail(w http.Respo
 		common.WriteJsonResp(w, errors.New("unauthorized"), nil, http.StatusForbidden)
 		return
 	}
+	ctx := r.Context()
+	ctx = context.WithValue(ctx, "token", token)
+
 	var err error
 	v := r.URL.Query()
 	resourceName := v.Get("name")
@@ -104,7 +108,7 @@ func (handler *ArgoApplicationRestHandlerImpl) GetApplicationDetail(w http.Respo
 			return
 		}
 	}
-	resp, err := handler.readService.GetAppDetail(resourceName, namespace, clusterId)
+	resp, err := handler.readService.GetAppDetailEA(ctx, resourceName, namespace, clusterId)
 	if err != nil {
 		handler.logger.Errorw("error in getting argo application app detail", "err", err, "resourceName", resourceName, "clusterId", clusterId)
 		common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)

api/argoApplication/wire_argoApplication.go

@@ -30,6 +30,7 @@ var ArgoApplicationWireSetFull = wire.NewSet(
 	config.NewArgoApplicationConfigServiceImpl,
 	wire.Bind(new(config.ArgoApplicationConfigService), new(*config.ArgoApplicationConfigServiceImpl)),
 
+	argoApplication.NewArgoApplicationServiceImpl,
 	argoApplication.NewArgoApplicationServiceExtendedServiceImpl,
 	wire.Bind(new(argoApplication.ArgoApplicationService), new(*argoApplication.ArgoApplicationServiceExtendedImpl)),
 

api/bean/AppView/AppView.go

@@ -294,3 +294,16 @@ type LinkOuts struct {
 	Link          string `json:"link,omitempty"`
 	Description   string `json:"description,omitempty"`
 }
+
+type AppStages struct {
+	AppId                   int    `json:"app_id,omitempty" sql:"app_id"`
+	CiTemplateId            int    `json:"ci_template_id,omitempty" sql:"ci_template_id"`
+	CiPipelineId            int    `json:"ci_pipeline_id,omitempty" sql:"ci_pipeline_id"`
+	ChartId                 int    `json:"chart_id,omitempty" sql:"chart_id"`
+	ChartGitRepoUrl         string `json:"chart_git_repo_url,omitempty" sql:"chart_git_repo_url"`
+	PipelineId              int    `json:"pipeline_id,omitempty" sql:"pipeline_id"`
+	YamlStatus              int    `json:"yaml_status,omitempty" sql:"yaml_status"`
+	YamlReviewed            bool   `json:"yaml_reviewed,omitempty" sql:"yaml_reviewed"`
+	DeploymentConfigRepoURL string `json:"deployment_config_repo_url" sql:"-"`
+	GitMaterialExists       int    `json:"-" sql:"-"`
+}

api/bean/gitOps/GitOpsConfig.go

@@ -42,10 +42,15 @@ type GitOpsConfigDto struct {
 	IsTLSKeyDataPresent  bool `json:"isTLSKeyDataPresent"`
 
 	// TODO refactoring: create different struct for internal fields
-	GitRepoName string `json:"-"`
-	UserEmailId string `json:"-"`
-	Description string `json:"-"`
-	UserId      int32  `json:"-"`
+	GitRepoName    string `json:"-"`
+	TargetRevision string `json:"-"`
+	UserEmailId    string `json:"-"`
+	Description    string `json:"-"`
+	UserId         int32  `json:"-"`
+}
+
+func (dto GitOpsConfigDto) GetHostUrl() string {
+	return dto.Host
 }
 
 type GitRepoRequestDto struct {
@@ -80,5 +85,5 @@ func IsGitOpsRepoNotConfigured(gitRepoUrl string) bool {
 }
 
 func IsGitOpsRepoConfigured(gitRepoUrl string) bool {
-	return len(gitRepoUrl) != 0 || gitRepoUrl != GIT_REPO_NOT_CONFIGURED
+	return !IsGitOpsRepoNotConfigured(gitRepoUrl)
 }

api/helm-app/HelmAppRestHandler.go

@@ -26,6 +26,7 @@ import (
 	"github.com/devtron-labs/devtron/pkg/appStore/installedApp/service/EAMode"
 	"github.com/devtron-labs/devtron/pkg/argoApplication"
 	"github.com/devtron-labs/devtron/pkg/argoApplication/helper"
+	clusterBean "github.com/devtron-labs/devtron/pkg/cluster/bean"
 	clientErrors "github.com/devtron-labs/devtron/pkg/errors"
 	"github.com/devtron-labs/devtron/pkg/fluxApplication"
 	bean2 "github.com/devtron-labs/devtron/pkg/k8s/application/bean"
@@ -467,7 +468,7 @@ func (handler *HelmAppRestHandlerImpl) DeleteApplication(w http.ResponseWriter,
 	// validate if the devtron-operator helm release, block that for deletion
 	if appIdentifier.ReleaseName == handler.serverEnvConfig.DevtronHelmReleaseName &&
 		appIdentifier.Namespace == handler.serverEnvConfig.DevtronHelmReleaseNamespace &&
-		appIdentifier.ClusterId == bean.DEFAULT_CLUSTER_ID {
+		appIdentifier.ClusterId == clusterBean.DefaultClusterId {
 		common.WriteJsonResp(w, errors.New("cannot delete this default helm app"), nil, http.StatusForbidden)
 		return
 	}

api/helm-app/bean/bean.go

@@ -23,7 +23,6 @@ import (
 )
 
 const (
-	DEFAULT_CLUSTER_ID                     = 1
 	SOURCE_DEVTRON_APP       SourceAppType = "devtron-app"
 	SOURCE_HELM_APP          SourceAppType = "helm-app"
 	SOURCE_EXTERNAL_HELM_APP SourceAppType = "external-helm-app"

api/k8s/application/k8sApplicationRestHandler.go

@@ -253,6 +253,8 @@ func (handler *K8sApplicationRestHandlerImpl) GetHostUrlsByBatch(w http.Response
 	}
 
 	token := r.Header.Get("token")
+	ctx := r.Context()
+	ctx = context.WithValue(ctx, "token", token)
 	var k8sAppDetail AppView.AppDetailContainer
 	var resourceTreeResponse *gRPC.ResourceTreeResponse
 	var clusterId int
@@ -276,7 +278,7 @@ func (handler *K8sApplicationRestHandlerImpl) GetHostUrlsByBatch(w http.Response
 			return
 		}
 		//RBAC enforcer Ends
-		appDetail, err := handler.helmAppService.GetApplicationDetail(r.Context(), appIdentifier)
+		appDetail, err := handler.helmAppService.GetApplicationDetail(ctx, appIdentifier)
 		if err != nil {
 			apiError := clientErrors.ConvertToApiError(err)
 			if apiError != nil {
@@ -303,7 +305,7 @@ func (handler *K8sApplicationRestHandlerImpl) GetHostUrlsByBatch(w http.Response
 		}
 		//RBAC enforcer Ends
 
-		appDetail, err := handler.argoApplicationReadService.GetAppDetail(appIdentifier.AppName, appIdentifier.Namespace, appIdentifier.ClusterId)
+		appDetail, err := handler.argoApplicationReadService.GetAppDetailEA(r.Context(), appIdentifier.AppName, appIdentifier.Namespace, appIdentifier.ClusterId)
 		if err != nil {
 			apiError := clientErrors.ConvertToApiError(err)
 			if apiError != nil {

api/module/ModuleRestHandler.go

@@ -19,6 +19,7 @@ package module
 import (
 	"encoding/json"
 	"errors"
+	"github.com/devtron-labs/devtron/pkg/module/bean"
 	"net/http"
 
 	"github.com/devtron-labs/devtron/api/restHandler/common"
@@ -135,7 +136,7 @@ func (impl ModuleRestHandlerImpl) HandleModuleAction(w http.ResponseWriter, r *h
 
 	// decode request
 	decoder := json.NewDecoder(r.Body)
-	var moduleActionRequestDto *module.ModuleActionRequestDto
+	var moduleActionRequestDto *bean.ModuleActionRequestDto
 	err = decoder.Decode(&moduleActionRequestDto)
 	if err != nil {
 		impl.logger.Errorw("error in decoding request in HandleModuleAction", "err", err)
@@ -184,7 +185,7 @@ func (impl ModuleRestHandlerImpl) EnableModule(w http.ResponseWriter, r *http.Re
 	}
 	// decode request
 	decoder := json.NewDecoder(r.Body)
-	var moduleEnableRequestDto module.ModuleEnableRequestDto
+	var moduleEnableRequestDto bean.ModuleEnableRequestDto
 	err = decoder.Decode(&moduleEnableRequestDto)
 	if err != nil {
 		impl.logger.Errorw("error in decoding request in ModuleEnableRequestDto", "err", err)

api/module/wire_module.go

@@ -18,6 +18,8 @@ package module
 
 import (
 	"github.com/devtron-labs/devtron/pkg/module"
+	"github.com/devtron-labs/devtron/pkg/module/bean"
+	"github.com/devtron-labs/devtron/pkg/module/read"
 	moduleRepo "github.com/devtron-labs/devtron/pkg/module/repo"
 	moduleDataStore "github.com/devtron-labs/devtron/pkg/module/store"
 	"github.com/google/wire"
@@ -28,9 +30,11 @@ var ModuleWireSet = wire.NewSet(
 	wire.Bind(new(module.ModuleActionAuditLogRepository), new(*module.ModuleActionAuditLogRepositoryImpl)),
 	moduleRepo.NewModuleRepositoryImpl,
 	wire.Bind(new(moduleRepo.ModuleRepository), new(*moduleRepo.ModuleRepositoryImpl)),
+	read.NewModuleReadServiceImpl,
+	wire.Bind(new(read.ModuleReadService), new(*read.ModuleReadServiceImpl)),
 	moduleRepo.NewModuleResourceStatusRepositoryImpl,
 	wire.Bind(new(moduleRepo.ModuleResourceStatusRepository), new(*moduleRepo.ModuleResourceStatusRepositoryImpl)),
-	module.ParseModuleEnvConfig,
+	bean.ParseModuleEnvConfig,
 	moduleDataStore.InitModuleDataStore,
 	module.NewModuleServiceHelperImpl,
 	wire.Bind(new(module.ModuleServiceHelper), new(*module.ModuleServiceHelperImpl)),

api/restHandler/CommonRestHanlder.go

@@ -25,28 +25,29 @@ import (
 	"go.uber.org/zap"
 )
 
-type CommonRestHanlder interface {
+type CommonRestHandler interface {
 	GlobalChecklist(w http.ResponseWriter, r *http.Request)
+	EnvironmentVariableList(w http.ResponseWriter, r *http.Request)
 }
 
-type CommonRestHanlderImpl struct {
+type CommonRestHandlerImpl struct {
 	logger          *zap.SugaredLogger
 	userAuthService user.UserService
 	commonService   commonService.CommonService
 }
 
-func NewCommonRestHanlderImpl(
+func NewCommonRestHandlerImpl(
 	logger *zap.SugaredLogger,
 	userAuthService user.UserService,
-	commonService commonService.CommonService) *CommonRestHanlderImpl {
-	return &CommonRestHanlderImpl{
+	commonService commonService.CommonService) *CommonRestHandlerImpl {
+	return &CommonRestHandlerImpl{
 		logger:          logger,
 		userAuthService: userAuthService,
 		commonService:   commonService,
 	}
 }
 
-func (impl CommonRestHanlderImpl) GlobalChecklist(w http.ResponseWriter, r *http.Request) {
+func (impl CommonRestHandlerImpl) GlobalChecklist(w http.ResponseWriter, r *http.Request) {
 	userId, err := impl.userAuthService.GetLoggedInUser(r)
 	if userId == 0 || err != nil {
 		common.WriteJsonResp(w, err, "Unauthorized User", http.StatusUnauthorized)
@@ -61,3 +62,19 @@ func (impl CommonRestHanlderImpl) GlobalChecklist(w http.ResponseWriter, r *http
 
 	common.WriteJsonResp(w, err, res, http.StatusOK)
 }
+
+func (impl CommonRestHandlerImpl) EnvironmentVariableList(w http.ResponseWriter, r *http.Request) {
+	userId, err := impl.userAuthService.GetLoggedInUser(r)
+	if userId == 0 || err != nil {
+		common.WriteJsonResp(w, err, "Unauthorized User", http.StatusUnauthorized)
+		return
+	}
+	// TODO: ADD RBAC (if required)
+	res, err := impl.commonService.EnvironmentVariableList()
+	if err != nil {
+		impl.logger.Errorw("service err, EnvironmentVariableList", "err", err)
+		common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
+		return
+	}
+	common.WriteJsonResp(w, err, res, http.StatusOK)
+}

api/restHandler/CoreAppRestHandler.go

@@ -29,6 +29,8 @@ import (
 	"github.com/devtron-labs/devtron/pkg/build/git/gitProvider"
 	"github.com/devtron-labs/devtron/pkg/build/git/gitProvider/read"
 	pipelineBean "github.com/devtron-labs/devtron/pkg/build/pipeline/bean"
+	bean3 "github.com/devtron-labs/devtron/pkg/chart/bean"
+	read5 "github.com/devtron-labs/devtron/pkg/chart/read"
 	"github.com/devtron-labs/devtron/pkg/cluster/environment/repository"
 	read3 "github.com/devtron-labs/devtron/pkg/team/read"
 	"net/http"
@@ -101,6 +103,7 @@ type CoreAppRestHandlerImpl struct {
 	pipelineStageService    pipeline.PipelineStageService
 	ciPipelineRepository    pipelineConfig.CiPipelineRepository
 	teamReadService         read3.TeamReadService
+	chartReadService        read5.ChartReadService
 }
 
 func NewCoreAppRestHandlerImpl(logger *zap.SugaredLogger, userAuthService user.UserService, validator *validator.Validate, enforcerUtil rbac.EnforcerUtil,
@@ -112,7 +115,8 @@ func NewCoreAppRestHandlerImpl(logger *zap.SugaredLogger, userAuthService user.U
 	pipelineStageService pipeline.PipelineStageService, ciPipelineRepository pipelineConfig.CiPipelineRepository,
 	gitProviderReadService read.GitProviderReadService,
 	gitMaterialReadService read2.GitMaterialReadService,
-	teamReadService read3.TeamReadService) *CoreAppRestHandlerImpl {
+	teamReadService read3.TeamReadService,
+	chartReadService read5.ChartReadService) *CoreAppRestHandlerImpl {
 	handler := &CoreAppRestHandlerImpl{
 		logger:                  logger,
 		userAuthService:         userAuthService,
@@ -136,6 +140,7 @@ func NewCoreAppRestHandlerImpl(logger *zap.SugaredLogger, userAuthService user.U
 		pipelineStageService:    pipelineStageService,
 		ciPipelineRepository:    ciPipelineRepository,
 		teamReadService:         teamReadService,
+		chartReadService:        chartReadService,
 	}
 	return handler
 }
@@ -551,7 +556,7 @@ func (handler CoreAppRestHandlerImpl) buildAppEnvironmentDeploymentTemplate(appI
 		return nil, err, http.StatusBadRequest
 	}
 
-	appDeploymentTemplate, err := handler.chartService.FindLatestChartForAppByAppId(appId)
+	appDeploymentTemplate, err := handler.chartReadService.FindLatestChartForAppByAppId(appId)
 	if err != nil {
 		if err != pg.ErrNoRows {
 			handler.logger.Errorw("service err, GetDeploymentTemplate in GetAppAllDetail", "err", err, "appId", appId, "envId", envId)
@@ -1365,7 +1370,7 @@ func (handler CoreAppRestHandlerImpl) createDockerConfig(appId int, dockerConfig
 func (handler CoreAppRestHandlerImpl) createDeploymentTemplate(ctx context.Context, appId int, deploymentTemplate *appBean.DeploymentTemplate, userId int32) (error, int) {
 	handler.logger.Infow("Create App - creating deployment template", "appId", appId, "DeploymentStrategy", deploymentTemplate)
 
-	createDeploymentTemplateRequest := chart.TemplateRequest{
+	createDeploymentTemplateRequest := bean3.TemplateRequest{
 		AppId:               appId,
 		ChartRefId:          deploymentTemplate.ChartRefId,
 		IsAppMetricsEnabled: deploymentTemplate.ShowAppMetrics,
@@ -1839,7 +1844,7 @@ func (handler CoreAppRestHandlerImpl) createEnvDeploymentTemplate(appId int, use
 	chartEntry, err := handler.chartRepo.FindChartByAppIdAndRefId(appId, chartRefId)
 	if err != nil {
 		if pg.ErrNoRows == err {
-			templateRequest := chart.TemplateRequest{
+			templateRequest := bean3.TemplateRequest{
 				AppId:               appId,
 				ChartRefId:          chartRefId,
 				ValuesOverride:      []byte("{}"),