feat: migrate external argo cd application #6303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
nishant-d
requested changes
Jan 17, 2025
pkg/deployment/common/bean/bean.go
Outdated
| SyncPolicy string `json:"syncPolicy,omitempty"` | ||
| } | ||
|
|
||
| type ArgoCDSpec struct { |
There was a problem hiding this comment.
please make sure this is exact subset of argocd structure
pkg/deployment/common/bean/bean.go
Outdated
| ArgoCDSpec ArgoCDSpec `json:"argoCDSpec"` | ||
| } | ||
|
|
||
| func (r *ReleaseConfiguration) JSON() []byte { |
| func (impl *DeploymentConfigServiceImpl) IsDeploymentConfigUsed() bool { | ||
| return impl.deploymentServiceTypeConfig.UseDeploymentConfigData | ||
| newObj, err := ConvertDeploymentConfigDbObjToDTO(newDBObj) | ||
| if err != nil { |
There was a problem hiding this comment.
how this error is handled at runtime?
| if envId > 0 { | ||
| // if envId>0 then only env level config will be returned, | ||
| //for getting app level config envId should be zero | ||
| appAndEnvLevelConfig, err := impl.getEnvLevelDataForDevtronApps(appId, envId, appLevelConfig, false) |
There was a problem hiding this comment.
@nishant-d to revisit this logic
| appLevelConfig.ReleaseConfiguration = releaseConfig | ||
|
|
||
| if migrateDataIfAbsent { | ||
| _, err := impl.CreateOrUpdateConfig(nil, appLevelConfig, bean3.SYSTEM_USER_ID) |
There was a problem hiding this comment.
@nishant-d review migration logic
…gitops-client-refactoring
…into chore-deployment-config-refactoring
…factoring chore: deployment config refactorings
…into feat-resource-tree-support
feat: argocd resource tree support
* version matched with enterprise * vulnerability fix * argocd dependabot fixes * argo workflow dependabot fixes
…ring feat: Trigger flow refactoring
CRUD operations
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15200081 | Triggered | PGP Private Key | e082b02 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 15200082 | Triggered | PGP Private Key | e082b02 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 7214865 | Triggered | PGP Private Key | f44a592 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 15200083 | Triggered | PGP Private Key | f44a592 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
| 15200084 | Triggered | PGP Private Key | e082b02 | vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?