Skip to content

#2129: cleanup mvnd from review from PR #2061 #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hiepiscus wants to merge 4 commits into
base: main
Choose a base branch
from
Open

#2129: cleanup mvnd from review from PR #2061 #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fd69ac
#2129: add AutoCompletionRegistry.add(candidate, synonym)
Hiepiscus Jul 14, 2026
1040ced
#2129: move and group maven completions to MavenCommandlet
Hiepiscus Jul 14, 2026
9e3c090
Merge remote-tracking branch 'upstream/main' into 2129-cleanup-mvnd-f…
Hiepiscus Jul 14, 2026
eebce4a
#2129: remove comments
Hiepiscus Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cli/src/main/java/com/devonfw/tools/ide/completion/AutoCompletionRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ public void add(String candidate) {
this.candidates.add(candidate);
}

/**
* Adds a new completion candidate together with a synonym. For now this adds both values.
*
* @param candidate the candidate to add.
* @param synonym to add a long with the candidate
*/
public void add(String candidate, String synonym) {
add(candidate);
add(synonym);
}


/**
* Adds all candidates matching the given argument to the collector.
Expand Down
13 changes: 11 additions & 2 deletions cli/src/main/java/com/devonfw/tools/ide/tool/mvn/MavenCommandlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ protected MavenCommandlet(IdeContext context, String tool) {

super(context, tool, Set.of(Tag.JAVA, Tag.BUILD));
}

/**
* Initializes common Maven auto-completion candidates.
*
Expand Down Expand Up @@ -66,9 +66,18 @@ protected void initAutoCompletionRegistry(AutoCompletionRegistry registry) {
registry.add("-U");
registry.add("-o");
registry.add("-f");
registry.add("-s");
registry.add("-s", "--settings");
registry.add("-rf");
registry.add("-DdeployAtEnd=true");
registry.add("-Dmaven.multiModuleProjectDirectory=");
registry.add("-Dmaven.repo.local=");
registry.add("-Dmvnd.socketConnectTimeout=");
registry.add("-Dmvnd.socketFamily=");
registry.add("-Dmvnd.threadStackSize=");
registry.add("-T", "--threads");
registry.add("-Dstyle.color=");
registry.add("-Duser.dir=");
registry.add("-Duser.home=");
}
}

Expand Down
10 changes: 0 additions & 10 deletions cli/src/main/java/com/devonfw/tools/ide/tool/mvnd/Mvnd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ protected void initAutoCompletionRegistry(AutoCompletionRegistry registry) {
registry.add("--file");
registry.add("-Djava.home=");
registry.add("-Djdk.java.options=");
registry.add("-Dmaven.multiModuleProjectDirectory=");
registry.add("-Dmaven.repo.local=");
registry.add("--settings");
registry.add("-Dmvnd.buildTime=");
registry.add("--builder");
registry.add("-Dmvnd.cancelConnectTimeout=");
Expand Down Expand Up @@ -70,13 +67,6 @@ protected void initAutoCompletionRegistry(AutoCompletionRegistry registry) {
registry.add("-Dmvnd.registry=");
registry.add("-Dmvnd.rollingWindowSize=");
registry.add("--serial");
registry.add("-Dmvnd.socketConnectTimeout=");
registry.add("-Dmvnd.socketFamily=");
registry.add("-Dmvnd.threadStackSize=");
registry.add("--threads");
registry.add("-Dstyle.color=");
registry.add("-Duser.dir=");
registry.add("-Duser.home=");
}

@Override
Expand Down
Loading