#2129: cleanup mvnd from review from PR #2061#2166
Open
Hiepiscus wants to merge 4 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 29480084012Warning No base build found for commit Coverage: 72.193%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fixes #2129
This PR addresses the remaining review comments from PR #2061 that were intentionally left unimplemented because the original author is no longer available.
The focus of this cleanup is the auto-completion implementation. Since several completions are not specific to mvnd, common maven related completions have been moved to super class implementation to avoid duplication.
Implemented changes:
MavenCommandletsuper class.AutoCompletionRegistry.add(String candidate, String synonym)Testing instructions
install mvnd-> tool should be installed successfullymvnd --version-> the version installed should be displayedmvnd <TAB> <TAB>-> expect to still display the arguments e.g.--settingsmvn <TAB> <TAB> -> expect to display the arguments as well e.g.--settings`Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal