Skip to content

Skip 2.3.x devfiles for odo v2 check #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Apr 28, 2025

Description of Changes

Skips 2.3.x devfiles under the odo v2 check as it does for 2.2.x devfiles already: check_odov2.sh#L225

Related Issue(s)

fixes devfile/api#1679

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Ran bash test/check_odov2.sh against #602 changes, see "How To Test".

How To Test

  1. Create a fork of this branch
  2. Rebase to sv-nodejs-mongodb branch with a 2.3.0 devfile
  3. Run tests/check_odov2.sh

Notes To Reviewer

Any notes you would like to include for the reviewer.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when tests pass. small nit is if we can consolidate the checks into one line with ||, I'll leave that up to you if you want to implement it or not

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 28, 2025
@michael-valdron michael-valdron force-pushed the fix/odov2-ignores-devfile2.3.x branch from 301ac6f to d4c137d Compare April 28, 2025 20:18
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Apr 28, 2025
@michael-valdron
Copy link
Member Author

small nit is if we can consolidate the checks into one line with ||, I'll leave that up to you if you want to implement it or not

@Jdubrick Done ✔️

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 28, 2025
Copy link

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/retest-required

@michael-valdron
Copy link
Member Author

Documentation

Does any documentation need to be updated with your changes?
Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

N/A

@michael-valdron michael-valdron merged commit 3fac029 into devfile:main Apr 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip odo v2 check for schemaVersion greater than 2.2.0
2 participants