feat: Add devfile with Node.js web app and MongoDB components #602
Conversation
| @@ -0,0 +1,77 @@ | |||
| schemaVersion: 2.2.2 | |||
There was a problem hiding this comment.
@ibuziuk looks like 2.3.0 schema version is not supported by odo v3 yet
see this comment: #602 (review)
|
/needs-rebase EC check is failing as its missing recent patches in your branch. |
|
GH checks are failed because @michael-valdron @thepetk are you planning to add support for the 2.3.0 schema version in the PR checks? |
@svor Error for odo v3 seems to be unrelated, let me retry. I'll open a bug report if the download link remains broken. As for odo v2, this check should be skipped as it will never receive updates and there is plans to remove it (correct me if I'm wrong @thepetk). Looking at check_odov2.sh#L225 it appears we still need a skip condition for all |
|
#606 should unblock this. |
|
/needs-rebase @svor Try rebasing again. |
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
|
@michael-valdron thank you! Tests passed with odo v2, but I’m still encountering an issue with odo v3 check |
|
/retest |
There was a problem hiding this comment.
@svor Testing this locally I got the following error with odo v3 nightly build:
unable to parse devfile: error parsing devfile because of non-compliant data due to unable to find schema for version "2.3.0". The parser supports devfile schema for version 2.0.0, 2.1.0, 2.2.0, 2.2.1, 2.2.2, v1alpha2
Seems that odo has not implemented devfile 2.3.0 yet, so I'd recommend downgrading to devfile 2.2.2 (latest of 2.2.x devfiles and what odo v3 supports).
There was a problem hiding this comment.
@svor Also the starter project devfile version needs to be 2.2.2 as well:
__
/ \__ Initializing a new component
\__/ \
/ \__/ odo version: v3.16.1 (a50a5d265-nightly)
\__/
✓ Copying devfile from "../stacks/nodejs-mongodb/devfile.yaml"
◓ Downloading starter project "nodejs-mongodb-sample"
====================================================================================================================================
⚠ A Devfile is present inside the starter project; replacing the entire content of the current directory with the starter project
====================================================================================================================================
✓ Downloading starter project "nodejs-mongodb-sample" [568ms]
✗ error parsing devfile because of non-compliant data due to unable to find schema for version "2.3.0". The parser supports devfile schema for version 2.0.0, 2.1.0, 2.2.0, 2.2.1, 2.2.2, v1alpha2
Signed-off-by: Valeriy Svydenko <[email protected]>
|
Looks good now. I'll let @michael-valdron review one last time and merge just in case there are any additional comments. For me is good to be merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, svor, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
In the registry I don't see any stack that provides a component with data base. So, this pull request introduces a devfile with two components:
Node.js Application: A component to develop and run a simple Node.js web application.
Mongo Database: A component to run MongoDB, which the Node.js app will connect to for data storage.
The project sample also includes the necessary deployment configurations, enabling the easy deployment of both the Node.js app and MongoDB to a K8S cluster.
This setup will allow developers to quickly start working on a full-stack application with a working MongoDB instance, all within a K8S environment. The configurations and components are designed to streamline development and deployment in K8S.
Related Issue(s)
eclipse-che/che#23351
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Tested with Eclipse Che:
How To Test
Create a workspace on workspaces.openshift.com by clicking this button:
Execute Run the application command