Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Py3.12 in tests by constraining pyproj in lockfile to versions with wheels #745

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

ceholden
Copy link
Contributor

@ceholden ceholden commented Feb 5, 2025

This PR adds environment markers to the uv tooling configuration constraint-dependencies for pyproj, allowing us to have a lockfile with pyproj wheels for Python versions we support without restricting versions for downstream consumers.

I believe the path to supporting 3.13 in tests will require updating fiona<1.10 to something like fiona>1,<=1.10. It also looks safe to bump DuckDB in our lockfile but we will have to invalidate the CI cache so it doesn't point to extensions compiled for 1.1.3

@kylebarron
Copy link
Member

Thank you! I think it's fine to add only 3.12 to CI; 3.13 might be more trouble than it's worth

@ceholden
Copy link
Contributor Author

ceholden commented Feb 5, 2025

Thank you! I think it's fine to add only 3.12 to CI; 3.13 might be more trouble than it's worth

+1 I'll remove that for now. It looks like the install is choking on not having a wheel for fiona<1.10, but there are wheels available if we can relax that to support 1.10.x

@ceholden ceholden changed the title Support Py3.12 and Py3.13 in tests Support Py3.12 in tests Feb 5, 2025
@ceholden
Copy link
Contributor Author

ceholden commented Feb 5, 2025

Relocking bumped DuckDB to 1.2 and I think there's some caching of DuckDB extensions going on that caused the last CI failures. I undid the bump in uv.lock for DuckDB for now to check if that's true

@ceholden ceholden changed the title Support Py3.12 in tests Support Py3.12 in tests by constraining pyproj in lockfile to versions with wheels Feb 5, 2025
@ceholden ceholden marked this pull request as ready for review February 5, 2025 17:57
@ceholden ceholden requested a review from kylebarron February 5, 2025 17:57
@kylebarron kylebarron merged commit 91e5936 into main Feb 5, 2025
5 checks passed
@kylebarron kylebarron deleted the ceh-test-py312-py313 branch February 5, 2025 17:59
@kylebarron
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants