Skip to content

Commit

Permalink
Support Py3.12 in tests by constraining pyproj in lockfile to version…
Browse files Browse the repository at this point in the history
…s with wheels (#745)

This PR adds environment markers to the `uv` tooling configuration
[constraint-dependencies](https://docs.astral.sh/uv/reference/settings/#constraint-dependencies)
for `pyproj`, allowing us to have a lockfile with `pyproj` wheels for
Python versions we support without restricting versions for downstream
consumers.

I believe the path to supporting 3.13 in tests will require updating
`fiona<1.10` to something like `fiona>1,<=1.10`. It also looks safe to
bump DuckDB in our lockfile but we will have to invalidate the CI cache
so it doesn't point to extensions compiled for `1.1.3`
  • Loading branch information
ceholden authored Feb 5, 2025
1 parent ab8a05a commit 91e5936
Show file tree
Hide file tree
Showing 3 changed files with 1,363 additions and 1,176 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.9, "3.10", "3.11"]
python-version: [3.9, "3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 7 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,10 @@ select = [
"__init__.py" = [
"F401", # Allow unused imports in __init__.py files
]

[tool.uv]
constraint-dependencies = [
# ensure lockfile grabs wheels for pyproj for each Python version
"pyproj==3.6; python_version == '3.9'",
"pyproj>=3.7; python_version >= '3.10'",
]
Loading

0 comments on commit 91e5936

Please sign in to comment.