Compiled binaries for v2.9.0; Windows, Linux and Mac OS (Apple silicon)#105
Open
cnuahs wants to merge 4 commits into
Open
Compiled binaries for v2.9.0; Windows, Linux and Mac OS (Apple silicon)#105cnuahs wants to merge 4 commits into
cnuahs wants to merge 4 commits into
Conversation
- remove '.' and '..' from exlude patterns (seems necessary on Windows; R2025b). - add 'mym.m' to list of includes. - make 'toolboxRootDir' and 'toolboxProjectDir' relative paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dimitri-yatsenko: MEX binaries here for all platforms.
One caveat, the last commit here makes three notable changes to
mktbx.mthat I needed to get it to work on Windows (R2025b).mym.mhas to be explicitly included. This actually fixes a bug in the version I initially committed, which left it out all together..(and likely..) need to be removed from theexcludepatterns. Without this, the entire directory gets excluded and you end up with an empty files list when packaging.toolboxRootDir(and likelytoolboxProjectDir) need to be relative paths, i.e.,.rather thanpwd.This last point became problematic on Linux, which seems to want
toolboxRootDirto be an absolute path, e.g.,pwd. This could be due to platform differences in path handling, or changes in thematlab.addons.toolboxmachinery in recent(ish) Matlab releases (this is probably more likely; my Linux machines are all on older releases <R2023b).If you run into problems when packaging look there.