Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-527 DEV-598 Update reusable and starter workflow for opensource repositories, mostly elements #25

Merged
merged 3 commits into from
Jul 5, 2024
Merged

DEV-527 DEV-598 Update reusable and starter workflow for opensource repositories, mostly elements #25

merged 3 commits into from
Jul 5, 2024

Conversation

yambottle
Copy link
Contributor

@yambottle yambottle commented Jun 24, 2024 •
edited
Loading

The goal of this P

  • Updated devcontainer, removed upload image as artifact, to avoid uploading large artifact crash and to save build time and storage
  • Added semantic-release same as for the dj-sciops/.github, it can auto-generate changelog from conventional commit and auto update version files bumped with the latest version tag
    • Deprecated make-release
  • Removed staging workflows and deprecated starter workflows
  • Added new starter workflows

Then maintainers can 'Add a caller workflow' by using the starter workflow:
Screenshot from 2024-06-24 14-54-11
then pick a caller workflow(screenshot showing the deprecated ones since this PR hasn't been merged yet)
Screenshot from 2024-06-24 14-54-23
then update if needed and commit
Screenshot from 2024-06-24 14-54-35

@yambottle yambottle changed the title Update devcontainer, add semantic-release, deprecate make-release Update devcontainer; add semantic-release; deprecate make-release; remove staging workflows and deprecated starter workflows Jun 24, 2024
@yambottle yambottle marked this pull request as draft June 24, 2024 19:21
@yambottle yambottle changed the title Update devcontainer; add semantic-release; deprecate make-release; remove staging workflows and deprecated starter workflows Update devcontainer; add semantic-release; deprecate make-release; remove staging workflows and deprecated starter workflows; added starter workflows Jun 24, 2024
@yambottle yambottle marked this pull request as ready for review June 24, 2024 19:53
@yambottle yambottle changed the title Update devcontainer; add semantic-release; deprecate make-release; remove staging workflows and deprecated starter workflows; added starter workflows Update reusable and starter workflow for opensource repositories, mostly elements Jun 24, 2024
@yambottle yambottle changed the title Update reusable and starter workflow for opensource repositories, mostly elements DEV-527 DEV-598 Update reusable and starter workflow for opensource repositories, mostly elements Jun 24, 2024
@yambottle yambottle merged commit 0bfb5f8 into datajoint:main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilagrosMarin MilagrosMarin MilagrosMarin approved these changes

@ttngu207 ttngu207 Awaiting requested review from ttngu207

@kushalbakshi kushalbakshi Awaiting requested review from kushalbakshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yambottle @MilagrosMarin