Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions acceptance/experimental/air/config-help/output.txt
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ config.compute.priority_class

>>> [CLI] experimental air run -h config.environment.dependencies
config.environment.dependencies
Inline list of packages to install. Not allowed alongside docker_image.
Inline list of packages to install. Not allowed alongside unity_catalog_image.

Type: list of strings
Required: no
Expand All @@ -108,12 +108,12 @@ config.compute.accelerator_type
Required: no

=== conditionally required leaf
>>> [CLI] experimental air run -h config.environment.docker_image.url
config.environment.docker_image.url
Fully qualified image URL, e.g. myregistry.io/team/train:v3.
>>> [CLI] experimental air run -h config.code_source.type
config.code_source.type
Kind of code source. Must be "snapshot", the only supported type.

Type: string
Required: when environment.docker_image is set
Required: when code_source is set

=== union field reports both accepted shapes
>>> [CLI] experimental air run -h config.code_source.snapshot.git.remote
Expand Down
2 changes: 1 addition & 1 deletion acceptance/experimental/air/config-help/script
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ title "leaf field"
trace $CLI experimental air run -h config.compute.accelerator_type

title "conditionally required leaf"
trace $CLI experimental air run -h config.environment.docker_image.url
trace $CLI experimental air run -h config.code_source.type

title "union field reports both accepted shapes"
trace $CLI experimental air run -h config.code_source.snapshot.git.remote
Expand Down
8 changes: 0 additions & 8 deletions acceptance/experimental/air/convert-to-dabs/docker.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions acceptance/experimental/air/convert-to-dabs/output.txt
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,3 @@ Unlike `air run` (which submits an ephemeral run), bundle deploy creates a
persistent job that is not garbage-collected. When you are done, remove the
job and its uploaded files with:
[CLI] bundle destroy

=== docker_image is not supported yet
>>> [CLI] experimental air convert-to-dabs docker.yaml --output-dir generated-docker
Error: environment.docker_image is not yet supported by convert-to-dabs

Exit code: 1
3 changes: 0 additions & 3 deletions acceptance/experimental/air/convert-to-dabs/script
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,3 @@ errcode trace $CLI experimental air convert-to-dabs train.yaml

title "--force overwrites it"
trace $CLI experimental air convert-to-dabs train.yaml --force

title "docker_image is not supported yet"
errcode trace $CLI experimental air convert-to-dabs docker.yaml --output-dir generated-docker
1 change: 0 additions & 1 deletion acceptance/experimental/air/help/output.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ Available Commands:
get Show status, configuration, and timing details for a specific run
list List your active runs for the current profile (use --all-status for finished runs)
logs Stream or fetch logs for a run
register-image Mirror a Docker image into the workspace registry
run Submit a training workload from a YAML config

Flags:
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions acceptance/experimental/air/register-image/out.test.toml

This file was deleted.

120 changes: 0 additions & 120 deletions acceptance/experimental/air/register-image/output.txt

This file was deleted.

37 changes: 0 additions & 37 deletions acceptance/experimental/air/register-image/script

This file was deleted.

30 changes: 0 additions & 30 deletions acceptance/experimental/air/register-image/test.toml

This file was deleted.

3 changes: 0 additions & 3 deletions experimental/air/cmd/air.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ experimental and may change in future versions.`,
cmd.AddCommand(newListCommand())
cmd.AddCommand(newLogsCommand())
cmd.AddCommand(newCancelCommand())
registerImageCommand := newRegisterImageCommand()
wrapRunErrorWithDebugTip(registerImageCommand)
cmd.AddCommand(registerImageCommand)
cmd.AddCommand(newConvertToDabsCommand())

return cmd
Expand Down
2 changes: 1 addition & 1 deletion experimental/air/cmd/air_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func TestNewRegistersAllSubcommands(t *testing.T) {
registered[c.Name()] = true
}

want := []string{"run", "get", "list", "logs", "cancel", "register-image", "convert-to-dabs"}
want := []string{"run", "get", "list", "logs", "cancel", "convert-to-dabs"}
for _, name := range want {
assert.True(t, registered[name], "subcommand %q is not registered", name)
}
Expand Down
6 changes: 1 addition & 5 deletions experimental/air/cmd/convert_to_dabs.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,10 @@ func convertToDabs(ctx context.Context, cfg *runConfig, configPath, bundleDir st
// idempotency_token is intentionally not mapped: it dedups a single runs/submit
// call, which has no analogue for a persistent, repeatedly-runnable bundle job.
//
// usage_policy_name resolution is not ported (mirrors the submit path), and
// docker images have no ai_runtime_task representation yet.
// usage_policy_name resolution is not ported (mirrors the submit path).
if cfg.UsagePolicyName != nil {
return nil, nil, errors.New("usage_policy_name is not yet supported by convert-to-dabs")
}
if cfg.Environment != nil && cfg.Environment.DockerImage != nil {
return nil, nil, errors.New("environment.docker_image is not yet supported by convert-to-dabs")
}
if snap := codeSnapshot(cfg); snap != nil {
// remote_volume points the code archive at a specific UC Volume. The bundle's
// artifact location is set bundle-wide via workspace.artifact_path, not
Expand Down
Loading
Loading