[air] Remove register-image command and docker_image run support - #6657
Open
maggiewang-db wants to merge 1 commit into
Open
[air] Remove register-image command and docker_image run support#6657maggiewang-db wants to merge 1 commit into
maggiewang-db wants to merge 1 commit into
Conversation
Ahead of the experimental/air release, drop the register-image command and the environment.docker_image run-config path (superseded by environment.unity_catalog_image). unity_catalog_image now inherits the 'custom image is exclusive with dependencies/version' guard docker_image had. Removes the register-image command and its image-registration client/credential helpers, the docker_image config type + accessors, the pre-submit image verification, the docker_image_url wiring in submit/validate-config, and the convert-to-dabs docker_image rejection. Updates unit + acceptance tests. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 34d58a5
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Before the
experimental/airrelease, this PR removes theregister-imagecommand and theenvironment.docker_imagerun-config path — both replaced byenvironment.unity_catalog_image.Removed:
register-imagecommand and its image-registration API client / credential-discovery / docker-config helpers.environment.docker_imageconfig (type, field, accessors) and the pre-submit image verification / tag re-resolution.docker_image_urlwiring in the submit payload and the validate-config pre-flight.convert-to-dabsdocker_image-not-supported rejection (the field no longer exists).convert-to-dabssupport forunity_catalog_imageyet because the Go SDK in Databricks CLI is stale and missing theunity_catalog_imagefield. I'll add theconvert-to-dabssupport once the Go SDK is updated.Behavior change:
environment.unity_catalog_imagenow inherits the exclusivitydocker_imagehad — it cannot be combined withdependenciesorversion, since a custom image already pins the full runtime.Tests
docker_imagecases, addedunity_catalog_imageexclusivity cases and a parse test.go test ./experimental/air/cmd/...passes.register-imagesuites and theconvert-to-dabsdocker_imagecase; regeneratedhelp/config-help/convert-to-dabsgoldens.go test ./acceptance -run TestAccept/experimental/airpasses.go buildandgo vet ./experimental/air/...are clean.This pull request and its description were written by Isaac.