Conversation
Collaborator
Author
|
can confirm that this breaks with multiple workers, working on a fix |
- automatically created pack jobs will be Paused instead of Ready if auto=false - a daggen job will be automatically created if auto=true
This reverts commit 1d51b83.
d4d3bbe to
11e4ff4
Compare
Collaborator
Author
|
ok, conflicts resolved to the point where the diff is correct 👍 |
39c5ef1 to
ac58962
Compare
Collaborator
|
@parkan @Sankara-Jefferson what is the status of this PR? Still being worked on, or was this work captured in a different PR? I noticed some force pushes near the end, so I am not sure if this code is still correct. |
Collaborator
Author
|
there is still potential relevance to the ideas in here, but it likely requires review and re-consideration in light of everything we've learned it might be better to close it for the moment and come back as needed (the force pushes after mine likely deal with the filter-repo) |
Collaborator
Author
|
actually it looks like anjor's work is likely going to supersede this anyway, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally titled "[WIP] enable producing DAG cars in inline mode (deferred approach)" but it turns out the problem might have been a lot simpler.
Still validating this but the issue appears to have been that scheduled daggen tasks would not succeed because of incorrect prioritization, where they would try to run before pack jobs and therefore error out. This was discovered while refactoring the scheduling mode, which is explained below. Unclear if inline mode somehow exacerbated the issue, will post an update on Monday.
This PR changes the scheduling semantics, fixes an issue where daggen tasks had higher scheduling priority than pack tasks and therefore tried to run ahead (erroring out), and adds a configurable auto mode which correctly executes the scan-pack-daggen sequence.
--autoboolean (default true) flag toprep create, which sequences the scan/pack/daggen tasks automaticallystart-packwithstart-daggen; previously pack tasks were automatically created byscanin a Ready state, which ran immediately -- now this will only happen ifautois on, otherwise the pack tasks are created in a Paused state and will wait forstart-packto rundaggentask in auto mode (this is currently done in thestart-scanhandler)TODO:
daggenworker (e.g. by checking state of dependency tasks and parking current task until they are complete)daggentask from the last pack task instead of at the beginning of the pipeline, however this requires introspecting the full packing task set, especially if they execute out of order or have failures--autoflag and usingstart-scanas the kickoff mechanism; an alternative approach may be to introduce a new command (--start-all or similar) however the semantics get messy and require threading a parameter through scan and pack tasks