[WIP] enable producing DAG cars in inline mode (attached-storage approach)#468
Closed
[WIP] enable producing DAG cars in inline mode (attached-storage approach)#468
Conversation
added 4 commits
September 19, 2024 15:06
- refactor validation logic for output storage requirements in CreateRequest and RemoveOutputStorageHandler - update pack check logic to skip data car writing even with output storages attaches - update error message
Collaborator
Author
|
a bit more on why I feel OK having the dag cars written to storage even in inline case: basically they are very, very small compared to the data/leaf cars! in this case I have deliberately chosen a "bad" input (the singularity repo) which is only ~146M but has 2K+ files in many deeply nested subdirs (git objects) and therefore a relatively large data tree, but the DAG car is only 180K (~0.1%) |
Collaborator
Author
|
closing in favor of #472 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the absolute minimal implementation that fixes #446
how this works:
--no-dagis specified--no-inlineand skip writing the data cars despite an output storage being attached, preserving the previous behaviorthe DAG car is then available in the output storage:
as well as under the pieces for the prep:
both can then be downloaded through
singularity downloadand together (concatenated here for purposes of demonstration, but adding each one to ipfs withdag import) provide the necessary structure to get the files out, note that as previously the data car does not allow extracting anything meaningful from the root, while the dag by itself does not contain the data:as an outcome from this exercise we immediately have some significant questions:
as well as some smaller ones:
start-scanimpliesstart-packrather than vice versa, similar issue to above