-
Notifications
You must be signed in to change notification settings - Fork 267
feat(funnels): CTA micro-liners to fact screen #4502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
49e0379
feat: add badge to facts
AmarTrebinjac 86b0b3a
fix: add conditionals
AmarTrebinjac 4964c8e
feat: add test
AmarTrebinjac 343305c
Merge branch 'main' into MI-894
AmarTrebinjac 7713ebc
feat: update icon size
AmarTrebinjac a95c7fe
fix: onion border color
AmarTrebinjac 6b25d49
feat: explicit typing
AmarTrebinjac de6b1db
Merge branch 'main' into MI-894
AmarTrebinjac c346899
Merge branch 'main' into MI-894
AmarTrebinjac f56760a
Merge branch 'main' into MI-894
sshanzel ef9b30b
fix: lint
sshanzel 481313c
Merge branch 'main' into MI-894
sshanzel 5be16bd
fix: spacing
sshanzel 602196e
Merge branch 'main' into MI-894
sshanzel 9a6604e
feat: cta note support
sshanzel 63e79d1
chore: update storybook components
sshanzel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import classNames from 'classnames'; | ||
import type { ReactNode } from 'react'; | ||
import React from 'react'; | ||
import { | ||
Typography, | ||
TypographyTag, | ||
TypographyType, | ||
} from './typography/Typography'; | ||
|
||
type BadgeProps = { | ||
icon?: ReactNode; | ||
label: string; | ||
variant: 'primary' | 'onion'; | ||
}; | ||
|
||
const variantToClassName: Record<BadgeProps['variant'], string> = { | ||
primary: 'border-border-subtlest-secondary text-surface-primary', | ||
onion: 'border-overlay-secondary-onion text-accent-onion-subtler', | ||
}; | ||
|
||
export const Badge = ({ label, icon, variant }: BadgeProps) => { | ||
return ( | ||
<div | ||
className={classNames( | ||
variantToClassName[variant], | ||
'flex items-center gap-1 rounded-20 border px-3 py-2', | ||
)} | ||
> | ||
{icon} | ||
<Typography type={TypographyType.Body} bold tag={TypographyTag.P}> | ||
{label} | ||
</Typography> | ||
</div> | ||
); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think the
useMemo
is needed for us here. Same goes to the other file.