feat(funnels): CTA micro-liners to fact screen #4502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
sshanzel
reviewed
May 20, 2025
AmarTrebinjac
changed the title
sshanzel
reviewed
May 21, 2025
Comment on lines
18
to
29
| const badgeComponent = useMemo(() => { | ||
| if (!badge?.cta) { | ||
| return null; | ||
| } | ||
| return ( | ||
| <Badge | ||
| label={badge.cta} | ||
| icon={<ReputationLightningIcon className="h-6 w-6" secondary />} | ||
| variant={badge.variant} | ||
| /> | ||
| ); | ||
| }, [badge?.cta, badge?.variant]); |
There was a problem hiding this comment.
Don't think the useMemo is needed for us here. Same goes to the other file.
sshanzel
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New badge component that can be used for micro liners in funnel fact:
I took the liberty to rename default and colorful to primary and onion, to stay in line with our other theme names.
DESIGN
Screenshot of all the layouts:
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-894
Preview domain
https://mi-894.preview.app.daily.dev