-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] High contrast themes #27514
Draft
hellendag
wants to merge
1
commit into
master
Choose a base branch
from
dish/colorblind-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[ui] High contrast themes #27514
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file removed
0
js_modules/dagster-ui/packages/ui-components/src/palettes/GlobalThemeStyles.tsx
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
125 changes: 125 additions & 0 deletions
125
js_modules/dagster-ui/packages/ui-components/src/theme/darkHighContrastThemeColors.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
import {css} from 'styled-components'; | ||
|
||
export const darkHighContrastThemeColors = css` | ||
--browser-color-scheme: dark; | ||
--color-keyline-default: var(--color-translucent-gray15); | ||
--color-link-default: var(--color-core-blue200); | ||
--color-link-hover: var(--color-core-blue400); | ||
--color-link-disabled: var(--color-core-gray750); | ||
--color-text-default: var(--color-core-white); | ||
--color-text-light: var(--color-core-gray300); | ||
--color-text-lighter: var(--color-core-gray500); | ||
--color-text-disabled: var(--color-core-gray600); | ||
--color-text-red: var(--color-core-red2white00); | ||
--color-text-yellow: var(--color-core-white); | ||
--color-text-green: var(--color-core-white); | ||
--color-text-blue: var(--color-core-white); | ||
--color-text-olive: var(--color-core-white); | ||
--color-text-cyan: var(--color-core-white); | ||
--color-text-lime: var(--color-core-white); | ||
--color-background-default: var(--color-core-gray990); | ||
--color-background-default-hover: var(--color-core-gray950); | ||
--color-background-light: var(--color-core-gray950); | ||
--color-background-light-hover: var(--color-core-gray900); | ||
--color-background-lighter: var(--color-core-gray850); | ||
--color-background-lighter-hover: var(--color-core-gray800); | ||
--color-background-disabled: var(--color-core-gray800); | ||
--color-background-red: var(--color-translucent-lime15); | ||
--color-background-red-hover: var(--color-translucent-lime20); | ||
--color-background-yellow: var(--color-translucent-cyan15); | ||
--color-background-yellow-hover: var(--color-translucent-cyan20); | ||
--color-background-green: var(--color-translucent-blue15); | ||
--color-background-green-hover: var(--color-translucent-blue20); | ||
--color-background-blue: var(--color-translucent-gray20); | ||
--color-background-blue-hover: var(--color-translucent-gray25); | ||
--color-background-olive: var(--color-translucent-olive15); | ||
--color-background-oliver-hover: var(--color-translucent-olive20); | ||
--color-background-cyan: var(--color-translucent-cyan15); | ||
--color-background-cyan-hover: var(--color-translucent-cyan20); | ||
--color-background-lime: var(--color-translucent-lime15); | ||
--color-background-lime-hover: var(--color-translucent-lime20); | ||
--color-background-gray: var(--color-translucent-gray15); | ||
--color-background-gray-hover: var(--color-translucent-gray20); | ||
--color-border-default: var(--color-core-gray800); | ||
--color-border-hover: var(--color-core-gray700); | ||
--color-border-disabled: var(--color-core-gray600); | ||
--color-focus-ring: var(--color-core-white); | ||
--color-accent-primary: var(--color-core-gray150); | ||
--color-accent-primary-hover: var(--color-core-gray50); | ||
--color-accent-reversed: var(--color-core-gray950); | ||
--color-accent-reversed-hover: var(--color-core-gray800); | ||
--color-accent-red: var(--color-core-lime500); | ||
--color-accent-red-hover: var(--color-core-lime600); | ||
--color-accent-yellow: var(--color-core-cyan500); | ||
--color-accent-yellow-hover: var(--color-core-cyan600); | ||
--color-accent-green: var(--color-core-blue400); | ||
--color-accent-green-hover: var(--color-core-blue500); | ||
--color-accent-blue: var(--color-core-gray600); | ||
--color-accent-blue-hover: var(--color-core-gray500); | ||
--color-accent-cyan: var(--color-core-cyan500); | ||
--color-accent-cyan-hover: var(--color-core-cyan600); | ||
--color-accent-lime: var(--color-core-lime500); | ||
--color-accent-lime-hover: var(--color-core-lime600); | ||
--color-accent-lavender: var(--color-core-blue800); | ||
--color-accent-lavender-hover: var(--color-core-blue700); | ||
--color-accent-olive: var(--color-core-olive500); | ||
--color-accent-olive-hover: var(--color-core-olive600); | ||
--color-accent-gray: var(--color-core-gray500); | ||
--color-accent-gray-hover: var(--color-core-gray600); | ||
--color-accent-white: var(--color-core-gray150); | ||
--color-always-white: var(--color-core-white); | ||
--color-dialog-background: var(--color-translucent-gray90); | ||
--color-tooltip-background: var(--color-core-gray850); | ||
--color-tooltip-text: var(--color-core-white); | ||
--color-popover-background: var(--color-core-gray900); | ||
--color-popover-background-hover: var(--color-core-gray850); | ||
--color-shadow-default: var(--color-translucent-gray90); | ||
--color-nav-background: var(--color-core-gray990); | ||
--color-nav-text: var(--color-core-gray400); | ||
--color-nav-text-hover: var(--color-core-gray300); | ||
--color-nav-text-selected: var(--color-core-white); | ||
--color-nav-button: var(--color-core-gray900); | ||
--color-nav-button-hover: var(--color-core-gray850); | ||
--color-lineage-edge: var(--color-core-gray850); | ||
--color-lineage-edge-highlighted: var(--color-core-gray500); | ||
--color-lineage-group-node-background: var(--color-core-gray900); | ||
--color-lineage-group-node-background-hover: var(--color-core-gray850); | ||
--color-lineage-group-node-border: var(--color-core-gray700); | ||
--color-lineage-group-node-border-hover: var(--color-core-gray400); | ||
--color-lineage-group-background: var(--color-translucent-dark-wash); | ||
--color-lineage-node-background: var(--color-core-gray850); | ||
--color-lineage-node-background-hover: var(--color-core-gray800); | ||
--color-lineage-node-border: var(--color-core-gray700); | ||
--color-lineage-node-border-hover: var(--color-core-gray400); | ||
--color-lineage-node-border-selected: var(--color-core-white); | ||
--color-data-viz-blue: var(--color-dataviz-blue200); | ||
--color-data-viz-blue-alt: var(--color-dataviz-blue100); | ||
--color-data-viz-blurple: var(--color-dataviz-blurple200); | ||
--color-data-viz-blurple-alt: var(--color-dataviz-blurple100); | ||
--color-data-viz-brown: var(--color-dataviz-brown200); | ||
--color-data-viz-brown-alt: var(--color-dataviz-brown100); | ||
--color-data-viz-cyan: var(--color-dataviz-cyan200); | ||
--color-data-viz-cyan-alt: var(--color-dataviz-cyan100); | ||
--color-data-viz-gray: var(--color-dataviz-gray200); | ||
--color-data-viz-gray-alt: var(--color-dataviz-gray100); | ||
--color-data-viz-green: var(--color-dataviz-green200); | ||
--color-data-viz-green-alt: var(--color-dataviz-green100); | ||
--color-data-viz-lime: var(--color-dataviz-lime200); | ||
--color-data-viz-lime-alt: var(--color-dataviz-lime100); | ||
--color-data-viz-orange: var(--color-dataviz-orange200); | ||
--color-data-viz-orange-alt: var(--color-dataviz-orange100); | ||
--color-data-viz-pink: var(--color-dataviz-pink200); | ||
--color-data-viz-pink-alt: var(--color-dataviz-pink100); | ||
--color-data-viz-red: var(--color-dataviz-red200); | ||
--color-data-viz-red-alt: var(--color-dataviz-red100); | ||
--color-data-viz-teal: var(--color-dataviz-teal200); | ||
--color-data-viz-teal-alt: var(--color-dataviz-teal100); | ||
--color-data-viz-violet: var(--color-dataviz-violet200); | ||
--color-data-viz-violet-alt: var(--color-dataviz-violet100); | ||
--color-data-viz-yellow: var(--color-dataviz-yellow200); | ||
--color-data-viz-yellow-alt: var(--color-dataviz-yellow100); | ||
--color-blue-gradient: linear-gradient( | ||
var(--color-core-gray950), | ||
var(--color-translucent-blue15) 100% | ||
); | ||
`; |
125 changes: 125 additions & 0 deletions
125
js_modules/dagster-ui/packages/ui-components/src/theme/lightHighContrastThemeColors.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
import {css} from 'styled-components'; | ||
|
||
export const lightHighContrastThemeColors = css` | ||
--browser-color-scheme: 'light'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The CSS custom property Spotted by Graphite Reviewer |
||
--color-keyline-default: var(--color-translucent-gray30); | ||
--color-link-default: var(--color-core-blue700); | ||
--color-link-hover: var(--color-core-blue500); | ||
--color-link-disabled: var(--color-core-gray150); | ||
--color-text-default: var(--color-core-gray990); | ||
--color-text-light: var(--color-core-gray700); | ||
--color-text-lighter: var(--color-core-gray500); | ||
--color-text-disabled: var(--color-core-gray400); | ||
--color-text-red: var(--color-core-gray990); | ||
--color-text-yellow: var(--color-core-gray990); | ||
--color-text-green: var(--color-core-gray990); | ||
--color-text-blue: var(--color-core-gray990); | ||
--color-text-olive: var(--color-core-gray990); | ||
--color-text-cyan: var(--color-core-gray990); | ||
--color-text-lime: var(--color-core-gray990); | ||
--color-background-default: var(--color-core-white); | ||
--color-background-default-hover: var(--color-core-gray10); | ||
--color-background-light: var(--color-core-gray10); | ||
--color-background-light-hover: var(--color-core-gray50); | ||
--color-background-lighter: var(--color-core-gray50); | ||
--color-background-lighter-hover: var(--color-core-gray100); | ||
--color-background-disabled: var(--color-core-gray150); | ||
--color-background-red: var(--color-translucent-yellow12); | ||
--color-background-red-hover: var(--color-translucent-yellow15); | ||
--color-background-yellow: var(--color-translucent-cyan12); | ||
--color-background-yellow-hover: var(--color-translucent-cyan15); | ||
--color-background-green: var(--color-translucent-blue12); | ||
--color-background-green-hover: var(--color-translucent-blue15); | ||
--color-background-blue: var(--color-translucent-blue15); | ||
--color-background-blue-hover: var(--color-translucent-blue20); | ||
--color-background-olive: var(--color-translucent-olive12); | ||
--color-background-oliver-hover: var(--color-translucent-olive15); | ||
--color-background-cyan: var(--color-translucent-cyan12); | ||
--color-background-cyan-hover: var(--color-translucent-cyan15); | ||
--color-background-lime: var(--color-translucent-lime12); | ||
--color-background-lime-hover: var(--color-translucent-lime15); | ||
--color-background-gray: var(--color-translucent-gray12); | ||
--color-background-gray-hover: var(--color-translucent-gray15); | ||
--color-border-default: var(--color-core-gray200); | ||
--color-border-hover: var(--color-core-gray300); | ||
--color-border-disabled: var(--color-core-gray500); | ||
--color-focus-ring: var(--color-core-gray950); | ||
--color-accent-primary: var(--color-core-gray950); | ||
--color-accent-primary-hover: var(--color-core-gray800); | ||
--color-accent-reversed: var(--color-core-gray10); | ||
--color-accent-reversed-hover: var(--color-core-white); | ||
--color-accent-red: var(--color-core-yellow500); | ||
--color-accent-red-hover: var(--color-core-yellow600); | ||
--color-accent-yellow: var(--color-core-cyan500); | ||
--color-accent-yellow-hover: var(--color-core-cyan400); | ||
--color-accent-green: var(--color-core-blue500); | ||
--color-accent-green-hover: var(--color-core-blue400); | ||
--color-accent-blue: var(--color-core-gray500); | ||
--color-accent-blue-hover: var(--color-core-gray400); | ||
--color-accent-cyan: var(--color-core-red500); | ||
--color-accent-cyan-hover: var(--color-core-red400); | ||
--color-accent-lime: var(--color-core-lime500); | ||
--color-accent-lime-hover: var(--color-core-lime400); | ||
--color-accent-lavender: var(--color-core-blue200); | ||
--color-accent-lavender-hover: var(--color-core-blue100); | ||
--color-accent-olive: var(--color-core-olive500); | ||
--color-accent-olive-hover: var(--color-core-olive400); | ||
--color-accent-gray: var(--color-core-gray500); | ||
--color-accent-gray-hover: var(--color-core-gray400); | ||
--color-accent-white: var(--color-core-white); | ||
--color-always-white: var(--color-core-white); | ||
--color-dialog-background: var(--color-translucent-gray50); | ||
--color-tooltip-background: var(--color-core-gray850); | ||
--color-tooltip-text: var(--color-core-white); | ||
--color-popover-background: var(--color-core-white); | ||
--color-popover-background-hover: var(--color-core-gray50); | ||
--color-shadow-default: var(--color-translucent-gray30); | ||
--color-nav-background: var(--color-core-gray990); | ||
--color-nav-text: var(--color-core-gray400); | ||
--color-nav-text-hover: var(--color-core-gray300); | ||
--color-nav-text-selected: var(--color-core-white); | ||
--color-nav-button: var(--color-core-gray900); | ||
--color-nav-button-hover: var(--color-core-gray850); | ||
--color-lineage-edge: var(--color-core-gray100); | ||
--color-lineage-edge-highlighted: var(--color-core-gray400); | ||
--color-lineage-group-node-background: var(--color-core-gray10); | ||
--color-lineage-group-node-background-hover: var(--color-core-gray50); | ||
--color-lineage-group-node-border: var(--color-translucent-gray25); | ||
--color-lineage-group-node-border-hover: var(--color-translucent-gray25); | ||
--color-lineage-group-background: var(--color-translucent-light-wash); | ||
--color-lineage-node-background: var(--color-core-gray50); | ||
--color-lineage-node-background-hover: var(--color-core-gray100); | ||
--color-lineage-node-border: var(--color-core-gray150); | ||
--color-lineage-node-border-hover: var(--color-core-gray300); | ||
--color-lineage-node-border-selected: var(--color-core-gray990); | ||
--color-data-viz-blue: var(--color-dataviz-blue200); | ||
--color-data-viz-blue-alt: var(--color-dataviz-blue300); | ||
--color-data-viz-blurple: var(--color-dataviz-blurple200); | ||
--color-data-viz-blurple-alt: var(--color-dataviz-blurple300); | ||
--color-data-viz-brown: var(--color-dataviz-brown200); | ||
--color-data-viz-brown-alt: var(--color-dataviz-brown300); | ||
--color-data-viz-cyan: var(--color-dataviz-cyan200); | ||
--color-data-viz-cyan-alt: var(--color-dataviz-cyan300); | ||
--color-data-viz-gray: var(--color-dataviz-gray200); | ||
--color-data-viz-gray-alt: var(--color-dataviz-gray300); | ||
--color-data-viz-green: var(--color-dataviz-green200); | ||
--color-data-viz-green-alt: var(--color-dataviz-green300); | ||
--color-data-viz-lime: var(--color-dataviz-lime200); | ||
--color-data-viz-lime-alt: var(--color-dataviz-lime300); | ||
--color-data-viz-orange: var(--color-dataviz-orange200); | ||
--color-data-viz-orange-alt: var(--color-dataviz-orange300); | ||
--color-data-viz-pink: var(--color-dataviz-pink200); | ||
--color-data-viz-pink-alt: var(--color-dataviz-pink300); | ||
--color-data-viz-red: var(--color-dataviz-red200); | ||
--color-data-viz-red-alt: var(--color-dataviz-red300); | ||
--color-data-viz-teal: var(--color-dataviz-teal200); | ||
--color-data-viz-teal-alt: var(--color-dataviz-teal300); | ||
--color-data-viz-violet: var(--color-dataviz-violet200); | ||
--color-data-viz-violet-alt: var(--color-dataviz-violet300); | ||
--color-data-viz-yellow: var(--color-dataviz-yellow200); | ||
--color-data-viz-yellow-alt: var(--color-dataviz-yellow300); | ||
--color-blue-gradient: linear-gradient( | ||
var(--color-core-gray10), | ||
var(--color-translucent-blue10) 100% | ||
); | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS property
--color-background-oliver-hover
appears to be a typo and should be--color-background-olive-hover
to maintain naming consistency with its non-hover counterpart and align with the olive-based naming pattern used throughout the theme system.Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.