[ui] High contrast themes #27514
[ui] High contrast themes #27514
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| import {css} from 'styled-components'; | ||
|
|
||
| export const lightHighContrastThemeColors = css` | ||
| --browser-color-scheme: 'light'; |
There was a problem hiding this comment.
The CSS custom property --browser-color-scheme should have its value specified without quotes. Change 'light' to light.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| --color-background-blue: var(--color-translucent-gray20); | ||
| --color-background-blue-hover: var(--color-translucent-gray25); | ||
| --color-background-olive: var(--color-translucent-olive15); | ||
| --color-background-oliver-hover: var(--color-translucent-olive20); |
There was a problem hiding this comment.
The CSS property --color-background-oliver-hover appears to be a typo and should be --color-background-olive-hover to maintain naming consistency with its non-hover counterpart and align with the olive-based naming pattern used throughout the theme system.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit aee6450. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit aee6450. |
Summary & Motivation
How I Tested These Changes
Changelog