Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Added
- Add [data-testid] to items in the execution summary ([#391](https://github.com/cucumber/react-components/pull/391))

## [23.1.0] - 2025-06-15
### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/components/app/ExecutionSummary.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('<ExecutionSummary/>', () => {
</EnvelopesProvider>
)

expect(screen.getByTestId('setup.phrase')).to.contain.text(
expect(screen.getByTestId('cucumber.summary.setup.phrase')).to.contain.text(
'[email protected] with [email protected] on [email protected]'
)
})
Expand Down
12 changes: 6 additions & 6 deletions src/components/app/ExecutionSummary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ export const ExecutionSummary: FC = () => {
<>
{meta && (
<HeaderSection>
<HeaderItem>
<HeaderItem testId="cucumber.summary.setup">
<HeaderSubItem>
<ImplementationIcon implementation={meta.implementation} />
<RuntimeIcon runtime={meta.runtime} />
<OSIcon os={meta.os} />
</HeaderSubItem>
<span data-testid="setup.phrase">
<span data-testid="cucumber.summary.setup.phrase">
<VersionedTool {...meta.implementation} fallback="unknown tool" />
<em className={styles.conjunction}> with </em>
<VersionedTool {...meta.runtime} fallback="unknown runtime" />
Expand All @@ -55,7 +55,7 @@ export const ExecutionSummary: FC = () => {
</HeaderSection>
)}
<HeaderSection>
<HeaderItem>
<HeaderItem testId="cucumber.summary.status">
<HeaderSubItem>
<HealthChart />
<span>
Expand All @@ -68,7 +68,7 @@ export const ExecutionSummary: FC = () => {
</HeaderSubItem>
</HeaderItem>
{startDate && (
<HeaderItem>
<HeaderItem testId="cucumber.summary.timing">
<HeaderSubItem>
<FontAwesomeIcon aria-hidden="true" style={{ opacity: 0.75 }} icon={faStopwatch} />
<span>
Expand All @@ -86,14 +86,14 @@ export const ExecutionSummary: FC = () => {
</HeaderItem>
)}
{meta?.ci && (
<HeaderItem>
<HeaderItem testId="cucumber.summary.ci">
<HeaderSubItem>
<CIJobLink ci={meta.ci} />
</HeaderSubItem>
</HeaderItem>
)}
{meta?.ci?.git && (
<HeaderItem>
<HeaderItem testId="cucumber.summary.git">
<HeaderSubItem>
<CICommitLink ci={meta.ci} />
</HeaderSubItem>
Expand Down
8 changes: 6 additions & 2 deletions src/components/app/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@ export const HeaderSection: FC<PropsWithChildren> = ({ children }) => {
return <div className={styles.section}>{children}</div>
}

export const HeaderItem: FC<PropsWithChildren> = ({ children }) => {
return <div className={styles.item}>{children}</div>
export const HeaderItem: FC<PropsWithChildren<{ testId?: string }>> = ({ testId, children }) => {
return (
<div data-testid={testId} className={styles.item}>
{children}
</div>
)
}

export const HeaderSubItem: FC<PropsWithChildren> = ({ children }) => {
Expand Down