Skip to content

Add [data-testid] to items in the execution summary #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jun 24, 2025

πŸ€” What's changed?

Add some test ids to elements in the summary, making them easier to exclude from screenshot tests and for other test-related things.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented Jun 24, 2025

βœ… Deploy Preview for cucumber-react-preview ready!

Name Link
πŸ”¨ Latest commit 2e5fc15
πŸ” Latest deploy log https://app.netlify.com/projects/cucumber-react-preview/deploys/685a64579489f9000829a66f
😎 Deploy Preview https://deploy-preview-391--cucumber-react-preview.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@davidjgoss davidjgoss changed the title Add testids where needed Add [data-testid] to items in the execution summary Jun 24, 2025
@davidjgoss davidjgoss marked this pull request as ready for review June 24, 2025 08:40
@davidjgoss davidjgoss merged commit 4f3a761 into main Jun 24, 2025
6 checks passed
@davidjgoss davidjgoss deleted the add-test-ids branch June 24, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant